liblastlog2: fix operator precedence in conditional assignments

Fix operator precedence in ll2_rename_user() where != comparison was
taking precedence over assignment, causing retval to be assigned 0 or 1
instead of the actual function return value.

Fixes: https://github.com/util-linux/util-linux/issues/3756
Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/liblastlog2/src/lastlog2.c b/liblastlog2/src/lastlog2.c
index 020c77106cd6a8f1ee1915aecdeab788cb81f74c..f285dddb42a8e5eea9495e8d40c209f69fd6fbfa 100644 (file)
--- a/liblastlog2/src/lastlog2.c
+++ b/liblastlog2/src/lastlog2.c
@@ -519,12 +519,12 @@ ll2_rename_user(struct ll2_context *context, const char *user,
        if ((retval = open_database_rw(context, &db, error)) != 0)
                return retval;
 
-       if ((retval = read_entry(db, user, &ll_time, &tty, &rhost, &pam_service, error) != 0)) {
+       if ((retval = read_entry(db, user, &ll_time, &tty, &rhost, &pam_service, error)) != 0) {
                sqlite3_close(db);
                return retval;
        }
 
-       if ((retval = write_entry(db, newname, ll_time, tty, rhost, pam_service, error) != 0)) {
+       if ((retval = write_entry(db, newname, ll_time, tty, rhost, pam_service, error)) != 0) {
                sqlite3_close(db);
                free(tty);
                free(rhost);