hardlink: make reflink detection more robust [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/misc-utils/hardlink.c b/misc-utils/hardlink.c
index b93530861658b9c7c2f2b692cce628755a8f7b3f..d4f3ee3a35eb66cc19fd2a3542ddf34517931203 100644 (file)
--- a/misc-utils/hardlink.c
+++ b/misc-utils/hardlink.c
@@ -907,6 +907,9 @@ static int is_reflink(struct file *xa, struct file *xb)
        int af = open(xa->links->path, O_RDONLY),
            bf = open(xb->links->path, O_RDONLY);
 
+       if (af < 0 || bf < 0)
+               goto done;
+
        do {
                size_t i;
 
@@ -948,9 +951,10 @@ static int is_reflink(struct file *xa, struct file *xb)
 
        rc = 1;
 done:
-       close(af);
-       close(bf);
-
+       if (af >= 0)
+               close(af);
+       if (bf >= 0)
+               close(bf);
        return rc;
 }
 #endif /* USE_REFLINK */