]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
lsns: fix undefined reference to add_namespace_for_nsfd #3483
authorThomas Devoogdt <thomas.devoogdt@barco.com>
Tue, 25 Mar 2025 10:58:18 +0000 (11:58 +0100)
committerThomas Devoogdt <thomas.devoogdt@barco.com>
Tue, 25 Mar 2025 12:41:12 +0000 (13:41 +0100)
Fixes:

sys-utils/lsns-lsns.o: In function `read_process':
lsns.c:(.text+0x9e8): undefined reference to `add_namespace_for_nsfd'
collect2: error: ld returned 1 exit status

Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
sys-utils/lsns.c

index d91c001da6691ba8f67c85726cebbf3a82023dd4..124b6ec8ebc665bada9ce274489ec1603d05434d 100644 (file)
@@ -616,7 +616,10 @@ static void add_namespace_from_sock(struct lsns *ls, pid_t pid, uint64_t fd)
        if (get_namespace(ls, sb.st_ino))
                goto out_nsfd;
 
+#ifdef USE_NS_GET_API
        add_namespace_for_nsfd(ls, nsfd, sb.st_ino);
+#endif
+
 out_nsfd:
        close(nsfd);
 out_sk:
@@ -642,6 +645,7 @@ static void add_namespace_from_sock(struct lsns *ls __attribute__((__unused__)),
 {
 }
 #endif /* HAVE_LINUX_NET_NAMESPACE_H */
+
 /* Read namespaces open(2)ed explicitly by the process specified by `pc'. */
 static void read_opened_namespaces(struct lsns *ls, struct path_cxt *pc, pid_t pid)
 {
@@ -661,11 +665,13 @@ static void read_opened_namespaces(struct lsns *ls, struct path_cxt *pc, pid_t p
                if (st.st_dev == ls->nsfs_dev) {
                        if (get_namespace(ls, st.st_ino))
                                continue;
+#ifdef USE_NS_GET_API
                        int fd = ul_path_openf(pc, O_RDONLY, "fd/%ju", (uintmax_t) num);
                        if (fd >= 0) {
                                add_namespace_for_nsfd(ls, fd, st.st_ino);
                                close(fd);
                        }
+#endif
                } else if ((st.st_mode & S_IFMT) == S_IFSOCK) {
                        add_namespace_from_sock(ls, pid, num);
                }