]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
sulogin: only assign to variables written by signal handlers
authorCristian Rodríguez <crrodriguez@opensuse.org>
Sun, 15 Jan 2023 01:33:14 +0000 (01:33 +0000)
committerCristian Rodríguez <crrodriguez@opensuse.org>
Sun, 15 Jan 2023 01:33:14 +0000 (01:33 +0000)
Using post increment is not warranted to be atomic.

login-utils/sulogin.c

index e343f0530e3768e2161476d5ac5c58e853f928cf..e19a3b8b67031c8b04a2ae4e8a16ad94394f5c4a 100644 (file)
@@ -342,12 +342,12 @@ static void tcfinal(struct console *con)
 static void alrm_handler(int sig __attribute__((unused)))
 {
        /* Timeout expired */
-       alarm_rised++;
+       alarm_rised = 1;
 }
 
 static void chld_handler(int sig __attribute__((unused)))
 {
-       sigchild++;
+       sigchild = 1;
 }
 
 static void mask_signal(int signal, void (*handler)(int),