suL fix use after free on error

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index 9bc02319619c8742c2f18d97ae8b21ded0666c05..3dda84e532ba9ccfe8f8bc10d551ab6a7ee6f76e 100644 (file)
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -447,9 +447,10 @@ static void supam_open_session(struct su_context *su)
 
        rc = pam_open_session(su->pamh, 0);
        if (is_pam_failure(rc)) {
+               const char *msg = pam_strerror(su->pamh, rc);
+
                supam_cleanup(su, rc);
-               errx(EXIT_FAILURE, _("cannot open session: %s"),
-                    pam_strerror(su->pamh, rc));
+               errx(EXIT_FAILURE, _("cannot open session: %s"), msg);
        } else
                su->pam_has_session = 1;
 }