Nasty, rare and obscure off-by-one in DNSSEC hostname_cmp().

diff --git a/src/dnssec.c b/src/dnssec.c
index e09f3043f4c90ba7725cdc5ee9ee9b873711ef02..29848e1bd6ca7bdda4a5a8f6708b9e826882c73e 100644 (file)
--- a/src/dnssec.c
+++ b/src/dnssec.c
@@ -1394,8 +1394,8 @@ static int hostname_cmp(const char *a, const char *b)
       if (sb == b)
        return 1;
       
-      ea = sa--;
-      eb = sb--;
+      ea = --sa;
+      eb = --sb;
     }
 }