]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
sfdisk: do not free device name too soon [coverity scan]
authorSami Kerola <kerolasa@iki.fi>
Sun, 9 Aug 2020 12:58:10 +0000 (13:58 +0100)
committerKarel Zak <kzak@redhat.com>
Fri, 16 Oct 2020 10:00:53 +0000 (12:00 +0200)
Fixes use after free error.

CID: 360798
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
disk-utils/sfdisk.c

index 2e8d7ea0e5e0f9398e00412e1f894cac9604b8fd..4e12f87a5cfafa6f3e0d9bb16d59c63f962501a5 100644 (file)
@@ -621,7 +621,6 @@ done:
        if (f)
                fclose(f);
        free(buf);
-       free(devname);
        free(typescript);
 
        if (sf->noact)
@@ -632,6 +631,8 @@ done:
        } else if (rc)
                warn(_("%s: failed to move data"), devname);
 
+       free(devname);
+
        return rc;
 }