]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
Revert "libmount: (tab) avoid leaking memory allocated in loop"
authorThomas Weißschuh <thomas@t-8ch.de>
Wed, 4 Oct 2023 15:21:47 +0000 (17:21 +0200)
committerThomas Weißschuh <thomas@t-8ch.de>
Wed, 4 Oct 2023 15:21:47 +0000 (17:21 +0200)
coverity claims that this is now a use-after-free.
Let's revert the original change and make the code clearer before trying
another fix.

This reverts commit d36306a560fd6d747e18ab22fc1279f4a373f43d.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
libmount/src/tab.c

index c6be5369e3de5f62ff1880a185480b78251bd52e..60bef8b2d16b394bb065e0becd6061dfd4b9f6c2 100644 (file)
@@ -1856,7 +1856,6 @@ int __mnt_table_is_fs_mounted(struct libmnt_table *tb, struct libmnt_fs *fstab_f
                                if (!*p)
                                        tgt = tgt_prefix;       /* target is '/' */
                                else {
-                                       free(tgt_buf);
                                        if (asprintf(&tgt_buf, "%s/%s", tgt_prefix, p) <= 0) {
                                                rc = -ENOMEM;
                                                goto done;