]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
chmem: print warnings about failures always (not only with --verbose)
authorBenno Schulenberg <bensberg@telfort.nl>
Tue, 25 Mar 2025 10:42:58 +0000 (11:42 +0100)
committerKarel Zak <kzak@redhat.com>
Thu, 27 Mar 2025 09:50:46 +0000 (10:50 +0100)
This makes the handling of errors the same as some 90 lines down.

Signed-off-by: Benno Schulenberg <bensberg@telfort.nl>
sys-utils/chmem.c

index 4105d19695b00b7daa8ed98b4a72438752bbc93e..5ff344fd3c2459ad4d2e05934713fa913c331be7 100644 (file)
@@ -146,12 +146,12 @@ static int chmem_size(struct chmem_desc *desc, int enable, int zone_id)
 
                idxtostr(desc, index, str, sizeof(str));
                rc = ul_path_writef_string(desc->sysmem, onoff, "%s/state", name);
-               if (rc != 0 && desc->verbose) {
+               if (rc != 0) {
                        if (enable)
-                               fprintf(stdout, _("%s enable failed\n"), str);
+                               warn(_("%s enable failed"), str);
                        else
-                               fprintf(stdout, _("%s disable failed\n"), str);
-               } else if (rc == 0 && desc->verbose) {
+                               warn(_("%s disable failed"), str);
+               } else if (desc->verbose) {
                        if (enable)
                                fprintf(stdout, _("%s enabled\n"), str);
                        else