]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
logger: fix memory leak [ASAN and valgrind]
authorSami Kerola <kerolasa@iki.fi>
Sun, 13 Mar 2016 10:31:40 +0000 (10:31 +0000)
committerKarel Zak <kzak@redhat.com>
Mon, 14 Mar 2016 12:15:09 +0000 (13:15 +0100)
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
misc-utils/logger.c

index 7b88b17482f257775cb535b78d22db68691fa36c..1ef12cdd8d147680d6c5d08c07a2f7d359095163 100644 (file)
@@ -341,8 +341,10 @@ static int journald_entry(struct logger_ctl *ctl, FILE *fp)
        for (lines = 0; /* nothing */ ; lines++) {
                buf = NULL;
                sz = getline(&buf, &dummy, fp);
-               if (sz == -1)
+               if (sz == -1) {
+                       free(buf);
                        break;
+               }
                if (0 < sz && buf[sz - 1] == '\n') {
                        sz--;
                        buf[sz] = '\0';