]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
lscpu: skip frequencies of 0 MHz when getting minmhz
authorRicardo Neri <ricardo.neri-calderon@linux.intel.com>
Fri, 31 Jan 2025 03:25:32 +0000 (19:25 -0800)
committerKarel Zak <kzak@redhat.com>
Mon, 3 Feb 2025 12:32:26 +0000 (13:32 +0100)
read_mhz() sets cpu->mhz_min_freq from /sys/devices/system/cpu/cpuN/
cpufreq/cpuinfo_min_freq. The file read fails if cpuN is offline and
cpu->mhz_min_freq is left as 0. 0 MHz is treated as invalid frequency.

lsblk_cputype_get_minmhz() iterates through all possible CPUs to find the
minimum frequency. If one or more CPUs are offline, the minimum frequency
will be 0. This is reflected in the output of lscpu:

$ ./lscpu | grep min
CPU min MHz:                        0.0000

Ignore 0-MHz frequencies to find the actual minimum frequency:

$ ./lscpu | grep min
CPU min MHz:                     1200.0000

Reported-by: Thangamani Krishnan <thangamani.krishnan@intel.com>
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
sys-utils/lscpu-topology.c

index 547a3aca0e913ac3cd097e2a0f2772ed3a24cd91..36a217bc7712626d13ddac51be7180867fcb17a7 100644 (file)
@@ -660,6 +660,8 @@ float lsblk_cputype_get_minmhz(struct lscpu_cxt *cxt, struct lscpu_cputype *ct)
 
                if (!cpu || cpu->type != ct || !is_cpu_present(cxt, cpu))
                        continue;
+               if (!cpu->mhz_min_freq)
+                       continue;
                if (res < 0.0 || cpu->mhz_min_freq < res)
                        res = cpu->mhz_min_freq;
        }