]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
libfdisk: allow to resize in unsorted partition table
authorKarel Zak <kzak@redhat.com>
Wed, 19 Jul 2017 13:09:36 +0000 (15:09 +0200)
committerKarel Zak <kzak@redhat.com>
Wed, 19 Jul 2017 13:09:36 +0000 (15:09 +0200)
The current code assumes that partition offsets (starts) are sorted.
This is usual situation, but unsorted partition table is also valid...

Signed-off-by: Karel Zak <kzak@redhat.com>
libfdisk/src/partition.c

index bc52ea5735cbade7e2f1addbf872a56d34d5be6a..93e6d9a49171048a9abb00bd1bd1ee48ccc32c70 100644 (file)
@@ -1061,14 +1061,15 @@ static int resize_get_last_possible(
 
        while (fdisk_table_next_partition(tb, &itr, &pa) == 0) {
 
-               DBG(TAB, ul_debugobj(tb, " checking entry %p [start=%ju, end=%ju, size=%ju, %s %s %s]",
+               DBG(TAB, ul_debugobj(tb, " checking entry %p [partno=%zu start=%ju, end=%ju, size=%ju%s%s%s]",
                        pa,
+                       fdisk_partition_get_partno(pa),
                        (uintmax_t) fdisk_partition_get_start(pa),
                        (uintmax_t) fdisk_partition_get_end(pa),
                        (uintmax_t) fdisk_partition_get_size(pa),
-                       fdisk_partition_is_freespace(pa) ? "freespace" : "",
-                       fdisk_partition_is_nested(pa)    ? "nested"    : "",
-                       fdisk_partition_is_container(pa) ? "container" : "primary"));
+                       fdisk_partition_is_freespace(pa) ? " freespace" : "",
+                       fdisk_partition_is_nested(pa)    ? " nested"    : "",
+                       fdisk_partition_is_container(pa) ? " container" : ""));
 
                if (!fdisk_partition_has_start(pa) ||
                    !fdisk_partition_has_size(pa) ||
@@ -1147,6 +1148,11 @@ static int recount_resize(
        if (rc)
                return rc;
 
+       fdisk_table_sort_partitions(tb, fdisk_partition_cmp_start);
+
+       DBG(PART, ul_debugobj(tpl, "resize partition partno=%zu in table:", partno));
+       ON_DBG(PART, fdisk_debug_print_table(tb));
+
        cur = fdisk_table_get_partition_by_partno(tb, partno);
        if (!cur) {
                fdisk_unref_table(tb);