lib/xalloc: fix mamory leak in xgethostname() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/include/xalloc.h b/include/xalloc.h
index 7b685e71843172d221ef94a0484de1b7cd1fee58..1f29621ef709b71d89a87177c88a54af96036453 100644 (file)
--- a/include/xalloc.h
+++ b/include/xalloc.h
@@ -83,9 +83,11 @@ static inline char *xgethostname(void)
        size_t sz = get_hostname_max() + 1;
 
        name = xmalloc(sizeof(char) * sz);
-       if (gethostname(name, sz) != 0)
-               return NULL;
 
+       if (gethostname(name, sz) != 0) {
+               free(name);
+               return NULL;
+       }
        name[sz - 1] = '\0';
        return name;
 }

diff --git a/term-utils/agetty.c b/term-utils/agetty.c
index 7ac12f20148c9cc7571efa505ec10a0727fd2272..f745e680006b2be9914a69efd1c55890b4dbdb4d 100644 (file)
--- a/term-utils/agetty.c
+++ b/term-utils/agetty.c
@@ -1209,9 +1209,10 @@ static char *xgethostname(void)
        if (!name)
                log_err(_("failed to allocate memory: %m"));
 
-       if (gethostname(name, sz) != 0)
+       if (gethostname(name, sz) != 0) {
+               free(name);
                return NULL;
-
+       }
        name[sz - 1] = '\0';
        return name;
 }
@@ -1226,9 +1227,10 @@ static char *xgetdomainname(void)
        if (!name)
                log_err(_("failed to allocate memory: %m"));
 
-       if (getdomainname(name, sz) != 0)
+       if (getdomainname(name, sz) != 0) {
+               free(name);
                return NULL;
-
+       }
        name[sz - 1] = '\0';
        return name;
 #endif