last: possible buffer overflow fixed [smatch scan]

last.c +447 ttyconv(11) error: buffer overflow '(arg)' 3 <= 3

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

diff --git a/login-utils/last.c b/login-utils/last.c
index 598078045819302c32fb0500553e5d31b1967af5..50afe35cbe10814e787d3af5ed1af9d4ab2f63d3 100644 (file)
--- a/login-utils/last.c
+++ b/login-utils/last.c
@@ -444,7 +444,7 @@ ttyconv(char *arg) {
        if (strlen(arg) == 2) {
                /* either 6 for "ttyxx" or 8 for "console" */
                mval = xmalloc(8);
-               if (!strcmp(arg, "co"))
+               if (!strncmp(arg, "co", 2))
                        (void)strcpy(mval, "console");
                else {
                        (void)strcpy(mval, "tty");