lib/pager: fix improper use of negative value [coverity scan]

The close(2) cannot accept a negative number.

CID: 360777
Signed-off-by: Sami Kerola <kerolasa@iki.fi>

diff --git a/lib/pager.c b/lib/pager.c
index b3cf6ee79bfcded1abd7d6d986ee9c08698898c6..747521e137dbfde24b042c8398b387b5fe5de198 100644 (file)
--- a/lib/pager.c
+++ b/lib/pager.c
@@ -88,14 +88,14 @@ static int start_command(struct child_process *cmd)
        if (cmd->pid < 0) {
                if (need_in)
                        close_pair(fdin);
-               else if (cmd->in)
+               else if (0 <= cmd->in)
                        close(cmd->in);
                return -1;
        }
 
        if (need_in)
                close(fdin[0]);
-       else if (cmd->in)
+       else if (0 <= cmd->in)
                close(cmd->in);
        return 0;
 }