]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
tailf: fix open() return value check [coverity scan]
authorKarel Zak <kzak@redhat.com>
Fri, 11 Mar 2011 13:25:45 +0000 (14:25 +0100)
committerKarel Zak <kzak@redhat.com>
Mon, 18 Apr 2011 12:51:10 +0000 (14:51 +0200)
Signed-off-by: Karel Zak <kzak@redhat.com>
text-utils/tailf.c

index 2dcdba3f3d1d6505211369caa4206b4387bf2946..fa228433c1efe76742f76f566953499b88a0a92f 100644 (file)
@@ -91,7 +91,8 @@ roll_file(const char *filename, off_t *size)
        struct stat st;
        off_t pos;
 
-       if (!(fd = open(filename, O_RDONLY)))
+       fd = open(filename, O_RDONLY);
+       if (fd < 0)
                err(EXIT_FAILURE, _("cannot open \"%s\" for read"), filename);
 
        if (fstat(fd, &st) == -1)