]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
tests: fix rename subdir check that was failing in travis
authorSami Kerola <kerolasa@iki.fi>
Wed, 30 Jul 2014 21:21:08 +0000 (22:21 +0100)
committerSami Kerola <kerolasa@iki.fi>
Thu, 31 Jul 2014 06:11:57 +0000 (07:11 +0100)
Apparently some or all travis build servers has a bit older coreutils
version.  The coreutils v8.13 added a feature to readlink that allows
user to specify multiple arguments.  Earlier versions gave exactly the
type of error travis_script log has.

+readlink: extra operand `rename_aa/sublink.2'
+Try `readlink --help' for more information.

The commit 0f85e0535bd4e6d19fadca182e4d57660b6bb57b introduced the travis
readlink issue, and has caused failures for 8 days in row (builds 192 -
213).

Reference: https://travis-ci.org/karelzak/util-linux/builds
Reviewed-by: Bernhard Voelker <mail@bernhard-voelker.de>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
tests/ts/rename/subdir

index f83b2bf10c6bb2f22618e3497c7f818c4a49cefa..4ae7005a7d29db8309a9f28539ad5faf4e835bed 100755 (executable)
@@ -35,7 +35,9 @@ for i in rename_a{a,b}/sublink.{1..3}; do
        ln -s rename/aa $i
 done
 $TS_CMD_RENAME -s -v a x rename_a{a,b}/sublink.? >> $TS_OUTPUT 2>&1
-readlink rename_a{a,b}/sublink.?  >> $TS_OUTPUT 2>&1
+for i in rename_a{a,b}/sublink.?; do
+       readlink $i >> $TS_OUTPUT 2>&1
+done
 
 rm -rf rename_a{a,b}