]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
libmount: fix file descriptor leak
authorSami Kerola <kerolasa@iki.fi>
Thu, 6 Apr 2017 21:11:16 +0000 (22:11 +0100)
committerKarel Zak <kzak@redhat.com>
Mon, 10 Apr 2017 13:40:40 +0000 (15:40 +0200)
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
libmount/src/utils.c

index 7e028ee021203b716b66c28718d4c062ddaccbea..3b27135cdb692728441f86b5dab348654b0d02ec 100644 (file)
@@ -647,18 +647,17 @@ done:
 
 static int try_write(const char *filename)
 {
-       int fd;
+       int fd, ret = 0;
 
        if (!filename)
                return -EINVAL;
 
        fd = open(filename, O_RDWR|O_CREAT|O_CLOEXEC,
                            S_IWUSR|S_IRUSR|S_IRGRP|S_IROTH);
-       if (fd >= 0) {
-               close(fd);
-               return 0;
-       }
-       return -errno;
+       if (fd < 0)
+               ret = -errno;
+       close(fd);
+       return ret;
 }
 
 /**