login: does not ignore setgid() return code for non-roots

Reported-by: Steve Grubb <sgrubb@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/login-utils/login.c b/login-utils/login.c
index 5584c320267c87c8743029c81356771ba5bcb30d..bb4d91c9bbcd919f3ea1af6dd7f8a2c2da5bfff2 100644 (file)
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -1037,7 +1037,11 @@ Michael Riepe <michael@stud.uni-hannover.de>
     }
 #endif
 
-    setgid(pwd->pw_gid);
+    if (setgid(pwd->pw_gid) < 0 && pwd->pw_gid) {
+       syslog(LOG_ALERT, _("setgid() failed"));
+       exit(EXIT_FAILURE);
+    }
+
 
     if (*pwd->pw_shell == '\0')
       pwd->pw_shell = _PATH_BSHELL;