mount: improve code readability

Static analyzers (e.g., Coverity) have a hard time understanding why
'optarg' is tested for NULL, and later in another place, code assumes
that it's non-NULL. For idmapping, the optarg is required.

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/sys-utils/mount.c b/sys-utils/mount.c
index abed9a03abb92dc1f94544808630ce4d390e5b70..cf62e2dd2b5026529a40e2884621cc47a107b424 100644 (file)
--- a/sys-utils/mount.c
+++ b/sys-utils/mount.c
@@ -863,7 +863,7 @@ int main(int argc, char **argv)
                        break;
                case MOUNT_OPT_MAP_GROUPS:
                case MOUNT_OPT_MAP_USERS:
-                       if (optarg && *optarg == '=')
+                       if (*optarg == '=')
                                optarg++;
                        if (idmap && (*idmap == '/' || *optarg == '/')) {
                                warnx(_("bad usage"));