]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commitdiff
resize2fs: make minimum size estimates more reliable for mounted fs
authorJan Kara <jack@suse.cz>
Fri, 18 Oct 2019 12:50:59 +0000 (14:50 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 10 Nov 2019 13:13:53 +0000 (08:13 -0500)
Currently, the estimate of minimum filesystem size is using free blocks
counter in the superblock. The counter generally doesn't get updated
while the filesystem is mounted and thus the estimate is very unreliable
for a mounted filesystem. For some usecases such as automated
partitioning proposal to the user it is desirable that the estimate of
minimum filesystem size is reasonably accurate even for a mounted
filesystem. So use group descriptor counters of free blocks for the
estimate of minimum filesystem size. These get updated together with
block being allocated and so the resulting estimate is more accurate.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
resize/resize2fs.c

index c2e10471bfd1a7cc4f14f1fda5d624529a0e8f77..8a3d08db19f3c4b9c58b81f906388a2ec9caed28 100644 (file)
@@ -2926,11 +2926,11 @@ blk64_t calculate_minimum_resize_size(ext2_filsys fs, int flags)
                        fs->super->s_reserved_gdt_blocks;
 
        /* calculate how many blocks are needed for data */
-       data_needed = ext2fs_blocks_count(fs->super) -
-               ext2fs_free_blocks_count(fs->super);
-
-       for (grp = 0; grp < fs->group_desc_count; grp++)
+       data_needed = ext2fs_blocks_count(fs->super);
+       for (grp = 0; grp < fs->group_desc_count; grp++) {
                data_needed -= calc_group_overhead(fs, grp, old_desc_blocks);
+               data_needed -= ext2fs_bg_free_blocks_count(fs, grp);
+       }
 #ifdef RESIZE2FS_DEBUG
        if (flags & RESIZE_DEBUG_MIN_CALC)
                printf("fs requires %llu data blocks.\n", data_needed);