su: use switch() to split after fork

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index e004e22cf0ecc028a4e748ed6921ebc2dd35c514..b153909c8c5cc68c85b59e42f963fbd6aec1f2bb 100644 (file)
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -288,18 +288,22 @@ static void create_watching_parent(struct su_context *su)
        struct sigaction oldact[3];
        int status = 0;
 
-       memset(oldact, 0, sizeof(oldact));
-
-       child = fork();
-       if (child == (pid_t) - 1) {
+       switch ((int) (child = fork())) {
+       case -1: /* error */
                supam_cleanup(su, PAM_ABORT);
                err(EXIT_FAILURE, _("cannot create child process"));
-       }
+               break;
 
-       /* the child proceeds to run the shell */
-       if (child == 0)
+       case 0: /* child */
                return;
 
+       default: /* parent */
+               break;
+       }
+
+       memset(oldact, 0, sizeof(oldact));
+
+
        /* In the parent watch the child.  */
 
        /* su without pam support does not have a helper that keeps