misc: avoid some dead initialization warnings

Clang analyzer warnings:

Dead store, Dead initialization:

    lib/mbsedit.c:154:8: warning: Value stored to 'in' during its initialization is never read
            char *in = (char *) &c;
                  ^~   ~~~~~~~~~~~

    misc-utils/findmnt-verify.c:129:14: warning: Value stored to 'cn' during its initialization is never read
            const char *cn = tgt;
                        ^~   ~~~
Dead store, Dead increment:

    sys-utils/hwclock.c:1461:2: warning: Value stored to 'argv' is never read
            argv += optind;
            ^       ~~~~~~

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>

diff --git a/lib/mbsedit.c b/lib/mbsedit.c
index d464358fc2a33fe564e30d77c4278d7ab3e13888..e028c496dcec6f1d34bd400feff53be0ba06900a 100644 (file)
--- a/lib/mbsedit.c
+++ b/lib/mbsedit.c
@@ -151,7 +151,7 @@ static size_t mbs_insert(char *str, wint_t c, size_t *ncells)
 {
        /* all in bytes! */
        size_t n = 1, bytes;
-       char *in = (char *) &c;
+       char *in;
 
 #ifdef HAVE_WIDECHAR
        wchar_t wc = (wchar_t) c;
@@ -162,6 +162,7 @@ static size_t mbs_insert(char *str, wint_t c, size_t *ncells)
        in = in_buf;
 #else
        *ncells = 1;
+       in = (char *) &c;
 #endif
        bytes       = strlen(str);
 

diff --git a/misc-utils/findmnt-verify.c b/misc-utils/findmnt-verify.c
index b32901d6631813306c6c29ff63527e8ad03758ab..1cc62def97f295412f22aad3a52c58659dea3874 100644 (file)
--- a/misc-utils/findmnt-verify.c
+++ b/misc-utils/findmnt-verify.c
@@ -126,14 +126,13 @@ done:
 static int verify_target(struct verify_context *vfy)
 {
        const char *tgt = mnt_fs_get_target(vfy->fs);
-       const char *cn = tgt;
        struct stat sb;
 
        if (!tgt)
                return verify_err(vfy, _("undefined target (fs_file)"));
 
        if (!(flags & FL_NOCACHE)) {
-               cn = mnt_resolve_target(tgt, cache);
+               const char *cn = mnt_resolve_target(tgt, cache);
                if (!cn)
                        return -ENOMEM;
                if (strcmp(cn, tgt) != 0)

diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
index 98ee5bef5080b0c61accf2d49281185bcf255752..2f2c03a6f89aa28fb7d9f3af26f961ae981514e8 100644 (file)
--- a/sys-utils/hwclock.c
+++ b/sys-utils/hwclock.c
@@ -1457,10 +1457,7 @@ int main(int argc, char **argv)
                }
        }
 
-       argc -= optind;
-       argv += optind;
-
-       if (argc > 0) {
+       if (argc > optind) {
                warnx(_("%d too many arguments given"), argc);
                errtryhelp(EXIT_FAILURE);
        }