]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
libmount: fix memory leak on error [coverity scan]
authorKarel Zak <kzak@redhat.com>
Wed, 15 May 2019 15:25:04 +0000 (17:25 +0200)
committerKarel Zak <kzak@redhat.com>
Wed, 15 May 2019 15:25:04 +0000 (17:25 +0200)
Signed-off-by: Karel Zak <kzak@redhat.com>
libmount/src/context_umount.c

index 7c5893ae6c06c7f4d1ad9c35054292bb6c521c90..999cdb0166419051683ad5c64ba2b411c70a4416 100644 (file)
@@ -574,9 +574,10 @@ static int evaluate_permissions(struct libmnt_context *cxt)
 
                curr_user = mnt_get_username(getuid());
 
-               if (!mnt_context_switch_ns(cxt, ns_old))
+               if (!mnt_context_switch_ns(cxt, ns_old)) {
+                       free(curr_user);
                        return -MNT_ERR_NAMESPACE;
-
+               }
                if (!curr_user) {
                        DBG(CXT, ul_debugobj(cxt, "umount %s: cannot "
                                "convert %d to username", tgt, getuid()));