libext2: move buf variable completely under ifdef

If !WORDS_BIGENDIAN, it is pointless to test whether buf
is NULL, because it is initialized to NULL and never changed.
This makes Coverity complain, so we can just move all handling
of "buf" under the #ifdef.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/lib/ext2fs/ext_attr.c b/lib/ext2fs/ext_attr.c
index 52664ebe61e56facab1490c5c347ff882fe6e81f..ddcc89f7af4c60b93ff85982344c9e97023256b8 100644 (file)
--- a/lib/ext2fs/ext_attr.c
+++ b/lib/ext2fs/ext_attr.c
@@ -82,9 +82,9 @@ errcode_t ext2fs_write_ext_attr2(ext2_filsys fs, blk64_t block, void *inbuf)
 {
        errcode_t       retval;
        char            *write_buf;
+#ifdef WORDS_BIGENDIAN
        char            *buf = NULL;
 
-#ifdef WORDS_BIGENDIAN
        retval = ext2fs_get_mem(fs->blocksize, &buf);
        if (retval)
                return retval;
@@ -94,8 +94,9 @@ errcode_t ext2fs_write_ext_attr2(ext2_filsys fs, blk64_t block, void *inbuf)
        write_buf = (char *) inbuf;
 #endif
        retval = io_channel_write_blk64(fs->io, block, 1, write_buf);
-       if (buf)
-               ext2fs_free_mem(&buf);
+#ifdef WORDS_BIGENDIAN
+       ext2fs_free_mem(&buf);
+#endif
        if (!retval)
                ext2fs_mark_changed(fs);
        return retval;