]> git.ipfire.org Git - people/ms/u-boot.git/commitdiff
mx53loco: Remove unneeded 'retval' variable
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 28 Dec 2012 04:05:28 +0000 (04:05 +0000)
committerStefano Babic <sbabic@denx.de>
Sat, 5 Jan 2013 17:06:12 +0000 (18:06 +0100)
commit c73368150 (pmic: Extend PMIC framework to support multiple instances
of PMIC devices) introduced an extra 'retval' variable, but this is not
necessary since we have already the variable 'ret' in place.

So use 'ret' to store the return values from the pmic related calls and remove
'retval'.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
board/freescale/mx53loco/mx53loco.c

index 63a4f8baf3fec93f659b4bc51feed2f12eb70cf2..b1bfb903896d7d818c8c5f6d93ac7eaa559c17ba 100644 (file)
@@ -345,12 +345,11 @@ static int power_init(void)
        unsigned int val;
        int ret = -1;
        struct pmic *p;
-       int retval;
 
        if (!i2c_probe(CONFIG_SYS_DIALOG_PMIC_I2C_ADDR)) {
-               retval = pmic_dialog_init(I2C_PMIC);
-               if (retval)
-                       return retval;
+               ret = pmic_dialog_init(I2C_PMIC);
+               if (ret)
+                       return ret;
 
                p = pmic_get("DIALOG_PMIC");
                if (!p)
@@ -370,9 +369,9 @@ static int power_init(void)
        }
 
        if (!i2c_probe(CONFIG_SYS_FSL_PMIC_I2C_ADDR)) {
-               retval = pmic_init(I2C_PMIC);
-               if (retval)
-                       return retval;
+               ret = pmic_init(I2C_PMIC);
+               if (ret)
+                       return ret;
 
                p = pmic_get("FSL_PMIC");
                if (!p)