libext2fs: fix ext2fs_orphan_file_block_csum_set()

The function ext2fs_orphan_file_block_csum_set() isn't used by
e2fsprogs, but it was embarassingly broken.  Thanks to Darrick Wong
for pointing this out.

Fixes: 16534ff59444 ("e2fsck: fix big-endian support for orphan_file...")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/lib/ext2fs/orphan.c b/lib/ext2fs/orphan.c
index e256fd220b6cdbcf28de998ce147c4cec0b13e2a..d910f3c5fd14f5e97d814ca19a0c647fe8b24d91 100644 (file)
--- a/lib/ext2fs/orphan.c
+++ b/lib/ext2fs/orphan.c
@@ -250,14 +250,16 @@ errcode_t ext2fs_orphan_file_block_csum_set(ext2_filsys fs, ext2_ino_t ino,
                                            blk64_t blk, char *buf)
 {
        struct ext4_orphan_block_tail *tail;
+       errcode_t ret;
        __u32 crc;
 
        if (!ext2fs_has_feature_metadata_csum(fs->super))
                return 0;
 
        tail = ext2fs_orphan_block_tail(fs, buf);
-       return ext2fs_orphan_file_block_csum(fs, ino, blk, buf, &crc);
+       ret = ext2fs_orphan_file_block_csum(fs, ino, blk, buf, &crc);
        tail->ob_checksum = ext2fs_cpu_to_le32(crc);
+       return ret;
 }
 
 int ext2fs_orphan_file_block_csum_verify(ext2_filsys fs, ext2_ino_t ino,