]> git.ipfire.org Git - ipfire.org.git/commitdiff
fireinfo: Fix parsing invalid IP addresses.
authorMichael Tremer <michael.tremer@ipfire.org>
Sun, 9 Sep 2012 15:19:08 +0000 (17:19 +0200)
committerMichael Tremer <michael.tremer@ipfire.org>
Sun, 9 Sep 2012 15:19:08 +0000 (17:19 +0200)
fireinfo/fireinfod

index f51173c7aed0e8284408f9482c66176172a17933..da7ca44f28ccbc9def400981cbf5a8403f1f6940 100755 (executable)
@@ -304,7 +304,14 @@ class ProfileSendHandler(BaseHandler):
                # Get GeoIP information if address is not defined in rfc1918
                remote_ips = self.request.remote_ip.split(", ")
                for remote_ip in remote_ips:
-                       addr = ipaddr.IPAddress(remote_ip)
+                       try:
+                               addr = ipaddr.IPAddress(remote_ip)
+                       except ValueError:
+                               # Skip invalid IP addresses.
+                               continue
+
+                       # Check if the given IP address is from a
+                       # private network.
                        if addr.is_private:
                                continue