]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commitdiff
lib/{ext2fs,support}: fix 32-bit Windows build
authorEric Biggers <ebiggers@google.com>
Sat, 21 Jan 2023 20:32:13 +0000 (12:32 -0800)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 27 Jan 2023 17:38:31 +0000 (12:38 -0500)
_WIN32 is the standard macro to detect (native) Windows, regardless of
32-bit or 64-bit.  _WIN64 is for 64-bit Windows only.  Use _WIN32 where
_WIN64 was incorrectly being used.

This fixes several 32-bit Windows build errors, for example this one:

plausible.c: In function ‘print_ext2_info’:
plausible.c:109:31: error: ‘unix_io_manager’ undeclared (first use in this function); did you mean ‘undo_io_manager’?
  109 |                               unix_io_manager,
      |                               ^~~~~~~~~~~~~~~
      |                               undo_io_manager

Fixes: 86b6db9f5a43 ("libext2fs: code adaptation to use the Windows IO manager")
Cc: Paulo Antonio Alvarez <pauloaalvarez@gmail.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
lib/ext2fs/getsectsize.c
lib/support/plausible.c
util/subst.c

index 3a461eb9c6131b6705c59aff1b6f7d3863f9c3b5..bd978c53092fd6361a8c56cfe65d195d0701bab4 100644 (file)
  */
 errcode_t ext2fs_get_device_sectsize(const char *file, int *sectsize)
 {
-#ifdef _WIN64
+#ifdef _WIN32
        *sectsize = 512; // just guessing
        return 0;
-#else // not _WIN64
+#else // not _WIN32
 
        int     fd;
 
@@ -78,7 +78,7 @@ errcode_t ext2fs_get_device_sectsize(const char *file, int *sectsize)
        close(fd);
        return 0;
 
-#endif // ifdef _WIN64
+#endif // ifdef _WIN32
 }
 
 /*
@@ -117,11 +117,11 @@ int ext2fs_get_dio_alignment(int fd)
  */
 errcode_t ext2fs_get_device_phys_sectsize(const char *file, int *sectsize)
 {
-#ifdef _WIN64
+#ifdef _WIN32
 
        return ext2fs_get_device_sectsize(file, sectsize);
 
-#else // not _WIN64
+#else // not _WIN32
 
        int     fd;
 
@@ -147,5 +147,5 @@ errcode_t ext2fs_get_device_phys_sectsize(const char *file, int *sectsize)
        close(fd);
        return 0;
 
-#endif // ifdef _WIN64
+#endif // ifdef _WIN32
 }
index bbed2a70a94511255c620e126e98b8e13518ba62..349aa2c4fd53ff4f5b37bac2b9f061882d8b2b16 100644 (file)
@@ -103,7 +103,7 @@ static void print_ext2_info(const char *device)
        time_t                  tm;
 
        retval = ext2fs_open2(device, 0, EXT2_FLAG_64BITS, 0, 0,
-#ifdef _WIN64
+#ifdef _WIN32
                              windows_io_manager,
 #else
                              unix_io_manager,
index c0eda5cf89d544e6ae4be84979265dacb6dc54c4..be2a0dda4030d2d777eaed7ea056ece9cc51c6ba 100644 (file)
@@ -434,7 +434,7 @@ int main(int argc, char **argv)
                                        printf("Using original atime\n");
                                set_utimes(outfn, fileno(old), tv);
                        }
-#ifndef _WIN64
+#ifndef _WIN32
                        if (ofd >= 0)
                                (void) fchmod(ofd, 0444);
 #endif
@@ -444,7 +444,7 @@ int main(int argc, char **argv)
                } else {
                        if (verbose)
                                printf("Creating or replacing %s.\n", outfn);
-#ifndef _WIN64
+#ifndef _WIN32
                        if (ofd >= 0)
                                (void) fchmod(ofd, 0444);
 #endif