fsck: fix racing between unlock/unlink and open

Process A	Process B	Process C
open()
[creates file]
lock()
[succeed]
		open()
		[open existing]
		lock()...
running()
close()
		[...succeed]
unlink()
		running()
				open()
				[creates file] {BAD!}
				lock()
				[succeed] {BAD!}
				running() {BAD!}
		close()

Cons: leaves empty (unlocked/harmless) .lock files in /run/fsck/
Signed-off-by: Yuriy M. Kaminskiy <yumkam@gmail.com>

diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
index 05cfbc43905d0c51f0ff3922c125948aaafd022e..84d2dcc3d4056036325828579171b6059959cada 100644 (file)
--- a/disk-utils/fsck.c
+++ b/disk-utils/fsck.c
@@ -410,7 +410,6 @@ static void unlock_disk(struct fsck_instance *inst)
                printf(_("Unlocking %s.\n"), inst->lockpath);
 
        close(inst->lock);                      /* unlock */
-       unlink(inst->lockpath);
 
        free(inst->lockpath);