]>
git.ipfire.org Git - thirdparty/util-linux.git/log
Ruediger Meier [Tue, 23 Jan 2018 15:59:23 +0000 (16:59 +0100)]
fsck.cramfs: fix crash when superblock size is too small
This hopefully fixes the original problem addressed by the reverted
patch
7cb962c7 .
The bug was introduced by myself in
f991dbd3 "fsck.cramfs: allow smaller superblock sizes"
CC: Tobias Stoeckmann <tobias@stoeckmann.org>
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Tue, 23 Jan 2018 15:59:22 +0000 (16:59 +0100)]
Revert "fsck.cramfs: Fix bus error on broken file system."
This reverts commit
7cb962c77015e9383b53eeb22ce732cb5216bbc3 .
It can't be right that we mmap (start + super.size) bytes from a file
which is usually only super.size bytes large. The patch "fixed" a
problem when super.size is bad but now it fails for the correct case:
$ mkdir -p root/subdir
$ ./mkfs.cramfs -p root cramfs
$ ./fsck.cramfs cramfs
Bus error (core dumped)
We will fix the original problem later.
CC: Tobias Stoeckmann <tobias@stoeckmann.org>
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Karel Zak [Mon, 22 Jan 2018 16:09:25 +0000 (17:09 +0100)]
tests: use subtests for weeknum cal(1) tests
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 15:55:07 +0000 (16:55 +0100)]
tests: use subtests for weekarg cal(1) tests
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 15:54:06 +0000 (16:54 +0100)]
test: use subtests for jan1753 cal(1) test
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 14:59:06 +0000 (15:59 +0100)]
tests: merge year cal(1) tests
* merge tests
* use subtests for cal(1) calls
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 14:53:00 +0000 (15:53 +0100)]
tests: merge 1m and 3m cal(1) tests
* merge tests
* use subtests for cal(1) calls
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 14:46:01 +0000 (15:46 +0100)]
tests: merge sep1752 cal(1) tests
* merge tests
* use subtests for cal(1) calls
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 14:01:05 +0000 (15:01 +0100)]
tests: use subtests for sep1752w test
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 13:37:43 +0000 (14:37 +0100)]
tests: simplify cal(1) sep1752w test
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 13:26:39 +0000 (14:26 +0100)]
tests: add cal(1) --week=40 1752
Signed-off-by: Karel Zak <kzak@redhat.com>
J William Piggott [Mon, 22 Jan 2018 12:03:27 +0000 (07:03 -0500)]
cal: fix first week calculation
Commit
efafeaf set 1 Jan as week 1, but the change
was missed in week_to_day() and in the man page.
Before
cal --week=40 --iso 1752
October 1752
Su Mo Tu We Th Fr Sa
41 1 2 3 4 5 6 7
42 8 9 10 11 12 13 14
43 15 16 17 18 19 20 21
44 22 23 24 25 26 27 28
45 29 30 31
Patched
cal --week=40 --iso 1752
September 1752
Su Mo Tu We Th Fr Sa
36 1 2
37 3 4 5 6 7 8 9
38 10 11 12 13 14 15 16
39 17 18 19 20 21 22 23
40 24 25 26 27 28 29 30
Signed-off-by: J William Piggott <elseifthen@gmx.com>
J William Piggott [Mon, 22 Jan 2018 12:01:23 +0000 (07:01 -0500)]
cal: fix week calculations for 1752
Before:
cal --week=39 1752
September 1752
Su Mo Tu We Th Fr Sa
36 1 2 14 15 16
37 17 18 19 20 21 22 23
38 24 25 26 27 28 29 30
Patched:
cal --week=39 1752
October 1752
Su Mo Tu We Th Fr Sa
39 1 2 3 4 5 6 7
40 8 9 10 11 12 13 14
41 15 16 17 18 19 20 21
42 22 23 24 25 26 27 28
43 29 30 31
Signed-off-by: J William Piggott <elseifthen@gmx.com>
Karel Zak [Mon, 22 Jan 2018 13:01:42 +0000 (14:01 +0100)]
Merge branch 'patch-2' of https://github.com/sourcejedi/util-linux
* 'patch-2' of https://github.com/sourcejedi/util-linux:
mount(8): umount does not (anymore?) say `none busy'
Karel Zak [Mon, 22 Jan 2018 12:54:49 +0000 (13:54 +0100)]
mount: be more accurate in man page about propagation flags
Addresses: https://github.com/karelzak/util-linux/issues/565
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 12:31:22 +0000 (13:31 +0100)]
Merge branch 'master' of https://github.com/rluzynski/util-linux
* 'master' of https://github.com/rluzynski/util-linux:
cal: Use ALTMON_* correctly
Karel Zak [Mon, 22 Jan 2018 12:20:51 +0000 (13:20 +0100)]
lscpu: (arm) cleanup code
* check for strtol() errors
* fix indention
* fix coding style
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 12:08:11 +0000 (13:08 +0100)]
lscpu: move ARM decoding to lscpu-arm.c
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 11:59:11 +0000 (12:59 +0100)]
lscpu: move struct lscpu_desc header file
The lscpu code is growing and it seems better to allow to make code
more structured.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 22 Jan 2018 11:47:47 +0000 (12:47 +0100)]
Merge branch 'arm-cpus' of https://github.com/suihkulokki/util-linux
* 'arm-cpus' of https://github.com/suihkulokki/util-linux:
lscpu: Decode ARM CPUs
Rafal Luzynski [Tue, 21 Mar 2017 08:27:08 +0000 (09:27 +0100)]
cal: Use ALTMON_* correctly
cal: use ALTMON_* and _NL_ABALTMON_* constants to display
months in a standalone form correctly. These constants have just
been newly added to glibc. ALTMON_x has been used in BSD family
since 1990s and has been accepted as the future POSIX extension.
_NL_ABALTMON_* is exclusively a GNU extension but it is expected
to be added to POSIX in future.
More info: https://sourceware.org/bugzilla/show_bug.cgi?id=10871
J William Piggott [Thu, 18 Jan 2018 02:21:02 +0000 (21:21 -0500)]
cal: fix julian calendars for large years
Before:
cal --r julian 31 12
2147483646
December
2147483646
Su Mo Tu We Th Fr Sa
1 2 3 4 5 6 7
8 9 10 11 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30 31
Patched:
cal --r julian 31 12
2147483646
December
2147483646
Su Mo Tu We Th Fr Sa
1
2 3 4 5 6 7 8
9 10 11 12 13 14 15
16 17 18 19 20 21 22
23 24 25 26 27 28 29
30 31
Signed-off-by: J William Piggott <elseifthen@gmx.com>
Ruediger Meier [Sat, 20 Jan 2018 18:06:24 +0000 (19:06 +0100)]
build-sys: remove redundant EXTRA_DIST files
The sources of AC_CONFIG_FILES (*.in) are automatically
distributed.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Sat, 20 Jan 2018 18:06:23 +0000 (19:06 +0100)]
build-sys: avoid using prog_DEPENDENCIES
Use EXTRA_prog_DEPENDENCIES to have the benefit
of automake's automatic prog_DEPENDENCIES.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Sat, 20 Jan 2018 18:06:22 +0000 (19:06 +0100)]
build-sys: remove unneeded dependencies on bla.h.in
We have already automakes's automatic dependencies like
bla.h.in -> bla.h -> foo.o -> bar.la
An explicit direct dependency bla.h.in -> bar.la
is redundant and useless anyways.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Sat, 20 Jan 2018 18:06:21 +0000 (19:06 +0100)]
build-sys: automake is able to find headers in builddir ...
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Sat, 20 Jan 2018 18:06:20 +0000 (19:06 +0100)]
build-sys: remove generated headers from dist tar ball
Headers should only be listed in either *_HEADERS or
*_SOURCES, especially when we want nodist_*_HEADERS.
Since all the generated headers are made by configure we
don't even need to use BUILT_SOURCES or other tricks.
Also see automake docs 9.4.1 Built Sources Example:
case "Build bindir.h from configure"
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
J William Piggott [Sun, 24 Dec 2017 20:38:58 +0000 (15:38 -0500)]
hwclock: add --ul-debug implementing debug.h
Undocumented at this time, because it is a skeleton
implementation. More debugging points are to be added after
refactoring is complete, or ad hoc in the mean time.
When fully implemented, enough time may have passed that the
deprecated --debug could be used to replace --ul-debug.
[kzak@redhat.com: - use __UL_INIT_DEBUG_FROM_STRING() to initialize the mask
- add hwclock_init_debug()]
Coauthored-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: J William Piggott <elseifthen@gmx.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Alan Jenkins [Sun, 21 Jan 2018 16:41:17 +0000 (16:41 +0000)]
mount(8): umount does not (anymore?) say `none busy'
The closest I can get is with `mount`, so refer to that instead.
# mount none -t proc /proc
mount: /proc: none already mounted or mount point busy.
# umount /proc
umount: /proc: target is busy.
# (cd /root; umount proc)
umount: /proc: target is busy.
Signed-off-by: Alan Jenkins <alan.christopher.jenkins@gmail.com>
Riku Voipio [Thu, 18 Jan 2018 14:57:51 +0000 (16:57 +0200)]
lscpu: Decode ARM CPUs
Since the kernel developers have refused to make /proc/cpuinfo user
understandable, implement mapping in userspace. lscpu is available for
most users via util-linux, so store the information here.
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Mike Frysinger [Fri, 19 Jan 2018 02:22:46 +0000 (21:22 -0500)]
mount(8): point people to the proc(5) page for mount options
This page is out of date wrt proc mount options, so point it to the
proc(5) page which is kept up to date.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Karel Zak [Wed, 17 Jan 2018 15:30:06 +0000 (16:30 +0100)]
sfdisk: add hint about udev and flock to the man page
Addresses: https://github.com/karelzak/util-linux/issues/563
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 17 Jan 2018 13:41:56 +0000 (14:41 +0100)]
tests: mark fincore/count as KNOWN_FAIL
The test (or our expectations about Direct-IO) seems not robust
enough. I guess this is not fincore problem.
Signed-off-by: Karel Zak <kzak@redhat.com>
Carlos Santos [Sun, 14 Jan 2018 18:39:31 +0000 (16:39 -0200)]
docs: add ISC licence
Save the top 21 lines of sys-utils/rfkill.c as COPYING.ISC. This is
useful for Linux distributions an integration tools like Buildroot,
to collect detailed legal information for each package.
[kzak@redhat.com: - remove C-comments and rfkill header]
Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 17 Jan 2018 12:58:29 +0000 (13:58 +0100)]
include/debug: introduce __UL_INIT_DEBUG_FROM_STRING()
Let's make it possible to use debug.h without environment variables.
Suggested-by: J William Piggott <elseifthen@gmx.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
J William Piggott [Sun, 24 Dec 2017 20:37:36 +0000 (15:37 -0500)]
hwclock: rename --debug option to --verbose
Warn on --debug; do not fallthrough because
the message is lost in the verbose output.
Coauthored-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: J William Piggott <elseifthen@gmx.com>
J William Piggott [Tue, 16 Jan 2018 18:08:31 +0000 (13:08 -0500)]
cal: update man page
Update cal.1 with the new options --reform and --iso.
Also add information about the calendar systems used and
the difference between the --julian option and the Julian
calendar system.
Signed-off-by: J William Piggott <elseifthen@gmx.com>
J William Piggott [Tue, 16 Jan 2018 11:19:00 +0000 (06:19 -0500)]
cal: add option to set Gregorian reform date
Create the new option: --reform <1752|gregorian|iso|julian>
This adds the capability to display either the proleptic Gregorian or
the Julian calendar systems exclusively.
Also create the option --iso as alias of --reform=gregorian.
Signed-off-by: J William Piggott <elseifthen@gmx.com>
J William Piggott [Mon, 15 Jan 2018 16:06:36 +0000 (11:06 -0500)]
cal: move REFORMATION_YEAR to control struct
Signed-off-by: J William Piggott <elseifthen@gmx.com>
Karel Zak [Fri, 12 Jan 2018 12:46:49 +0000 (13:46 +0100)]
include/debug: improve debug message
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 12 Jan 2018 12:37:05 +0000 (13:37 +0100)]
include/debug: print info when addresses suppressed
Suggested-by: Peter Cordes <peter@cordes.ca>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 12 Jan 2018 11:38:58 +0000 (12:38 +0100)]
sfdisk: cleanup shortcuts in man page too
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 12 Jan 2018 11:04:16 +0000 (12:04 +0100)]
libfdisk: (script) be consistent in code with types
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 12 Jan 2018 10:59:22 +0000 (11:59 +0100)]
Merge branch 'mbsencode' of https://github.com/yontalcar/util-linux
* 'mbsencode' of https://github.com/yontalcar/util-linux:
tests: mark mbsencode as KNOWN_FAIL
tests: mbsencode - test for HAVE_WIDECHAR
lib/mbsalign: Fix escaping nonprintable multibyte characters
tests: mbsencode - removed emoji, added control unicode character
tests: add tests for encode functions from lib/mbsalign.c
lib/mbsalign: escape "\x" when HAVE_WIDECHAR not defined
Karel Zak [Fri, 12 Jan 2018 10:01:26 +0000 (11:01 +0100)]
include/debug: don't print pointer address for SUID programs
* introduce new flag __UL_DEBUG_FL_NOADDR to suppress pointer address printing
* use __UL_DEBUG_FL_NOADDR when SUID
* move ul_debugobj() to debugobj.h, and require UL_DEBUG_CURRENT_MASK
to provide access to the current mask from ul_debugobj(). It's better
than modify all ul_debugobj() calls and use the global mask as
argument.
* remove never used UL_DEBUG_DEFINE_FLAG
Reported-by: halfdog <me@halfdog.net>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 11 Jan 2018 14:18:00 +0000 (15:18 +0100)]
libfdisk: allow to start freespace for zero
This is necessary for disk labels like SUN where whole disk is possible
to address by partitions.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 11 Jan 2018 13:23:57 +0000 (14:23 +0100)]
libfdisk: (sun) fix n-1 bug and whole-disk
* set whole_disk variable if SUN_TAG_WHOLEDISK specified
* fix N-1 bug in add new partition according to template (script)
Addresses: https://github.com/karelzak/util-linux/issues/555
Signed-off-by: Karel Zak <kzak@redhat.com>
Vaclav Dolezal [Thu, 11 Jan 2018 13:19:23 +0000 (14:19 +0100)]
tests: mark mbsencode as KNOWN_FAIL
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Vaclav Dolezal [Thu, 11 Jan 2018 10:11:31 +0000 (11:11 +0100)]
tests: mbsencode - test for HAVE_WIDECHAR
Test only safe-ascii as it should behave in the same way.
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Vaclav Dolezal [Thu, 11 Jan 2018 09:42:22 +0000 (10:42 +0100)]
lib/mbsalign: Fix escaping nonprintable multibyte characters
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Vaclav Dolezal [Thu, 11 Jan 2018 09:38:43 +0000 (10:38 +0100)]
tests: mbsencode - removed emoji, added control unicode character
Emojis are apparently too recent to be reliably recognised as printable
on test machines.
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Karel Zak [Thu, 11 Jan 2018 09:09:48 +0000 (10:09 +0100)]
Merge branch 'fixes' of https://github.com/rudimeier/util-linux
Tony Asleson [Tue, 9 Jan 2018 21:08:12 +0000 (15:08 -0600)]
libblkid: Add support for stratis
Initial support for stratis, ref.
https://github.com/stratis-storage
[kzak@redhat.com: - remove C++ comment]
Signed-off-by: Tony Asleson <tasleson@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Vaclav Dolezal [Thu, 21 Dec 2017 14:10:15 +0000 (15:10 +0100)]
tests: add tests for encode functions from lib/mbsalign.c
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Ruediger Meier [Fri, 1 Dec 2017 19:57:24 +0000 (20:57 +0100)]
misc: fix printf i386 compiler warnings
sys-utils/lsns.c:683:2: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘ino_t’ [-Werror=format=]
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Karel Zak [Tue, 9 Jan 2018 11:12:50 +0000 (12:12 +0100)]
libfdisk: (script) support R (RAID) and V (LVM) shortcuts
Addresses: https://github.com/karelzak/util-linux/issues/560
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 8 Jan 2018 11:43:22 +0000 (12:43 +0100)]
libfdisk: (gpt) add VMware specific UUIDs
Addresses: https://github.com/karelzak/util-linux/issues/559
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 3 Jan 2018 12:59:59 +0000 (13:59 +0100)]
libmount: fix mnt_table_is_fs_mounted() for rbind
There is no difference between "bind" and "rbind" if we want to FS
root to search for the FS in mountinfo file.
fstab:
/dev/sdc1 /mnt/foo xfs defaults 0 0
/mnt/foo /mnt/test none rw,rbind 0 0
use -a more than once:
mount -a
mount -a
/proc/mounts (the current result):
/dev/sdc1 /mnt/foo xfs rw,relatime,attr2,inode64,noquota 0 0
/dev/sdc1 /mnt/test xfs rw,relatime,attr2,inode64,noquota 0 0
/dev/sdc1 /mnt/test xfs rw,relatime,attr2,inode64,noquota 0 0
/dev/sdc1 /mnt/foo xfs rw,relatime,attr2,inode64,noquota 0 0
expected (fixed version) result:
/dev/sdc1 /mnt/foo xfs rw,relatime,attr2,inode64,noquota 0 0
/dev/sdc1 /mnt/test xfs rw,relatime,attr2,inode64,noquota 0 0
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=
1528959
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 2 Jan 2018 15:50:31 +0000 (16:50 +0100)]
libfdisk: (dos) fix max heads
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 2 Jan 2018 15:43:22 +0000 (16:43 +0100)]
libfdisk: extend API to provide label specific geometry ranges
Now fdisk provides DOS specific geometry ranges in expert menu.
Addresses: https://github.com/karelzak/util-linux/issues/556
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Sun, 3 Dec 2017 15:43:25 +0000 (15:43 +0000)]
rtcwake: wait stdin to settle down before entering a system sleep
This can delay entering to system sleep up to 0.28 seconds while discarding
input, when stdin is interactive device.
[kzak@redhat.com: - add note to the man page]
Reference: https://github.com/karelzak/util-linux/issues/527
See-also:
a85c39013491713ac0d9e24fd0f07b4fabdcfc17
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 2 Jan 2018 13:48:01 +0000 (14:48 +0100)]
sfdisk: wait before re-read
The original old (v2.13) fdisk had sleep(2) beany ideafore re-read ioctl. It
seems overkill, but short sleep is probably a good idea as we call
re-read on sfdisk start and at the end. It's possible that sfdisk is
too fast and the initial re-read is not gone yet.
It would be nice to have something more elegant than sleep, any idea?
Addresses: https://github.com/karelzak/util-linux/issues/557
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 2 Jan 2018 13:06:40 +0000 (14:06 +0100)]
Merge branch 'patch-1' of https://github.com/kenyon/util-linux
Karel Zak [Tue, 2 Jan 2018 13:05:37 +0000 (14:05 +0100)]
Merge branch 'master' of https://github.com/yurchor/util-linux
Karel Zak [Tue, 2 Jan 2018 10:08:03 +0000 (11:08 +0100)]
lib/sha1: use proper WORDS_BIGENDIAN macro
The original code uses BYTE_ORDER, but we use WORDS_BIGENDIAN in
utl-linux.
Reported-by: Andreas Schwab <schwab@linux-m68k.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Yuri Chornoivan [Sun, 31 Dec 2017 11:07:43 +0000 (13:07 +0200)]
Fix minor typo: priorty -> priority
Kenyon Ralph [Sat, 23 Dec 2017 21:44:34 +0000 (13:44 -0800)]
rename.1: fix typo, where -> were
Vaclav Dolezal [Thu, 21 Dec 2017 14:23:56 +0000 (15:23 +0100)]
lib/mbsalign: escape "\x" when HAVE_WIDECHAR not defined
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Karel Zak [Wed, 20 Dec 2017 12:01:43 +0000 (13:01 +0100)]
lib/mbsalign: encode \x to \xecx
Don't encode stand alone '\', our encoding is about \x<hex>, so we
need to care about \x prefix only.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 20 Dec 2017 11:31:10 +0000 (12:31 +0100)]
libfdisk: (gpt) use fdisk_warn() for failed name setting
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 20 Dec 2017 11:29:16 +0000 (12:29 +0100)]
Merge branch 'gpt-part-name' of https://github.com/yontalcar/util-linux
* 'gpt-part-name' of https://github.com/yontalcar/util-linux:
libfdisk: return bytes processed from gpt_entry_set_name(), process rc
libfdisk: allocate enough bytes for ucs2 to utf8 encoding
libfdisk: gpt: properly encode string on rename
lib/mbsalign: encode backslash to prevent ambiguity
Karel Zak [Tue, 19 Dec 2017 12:46:35 +0000 (13:46 +0100)]
tests: don't use mount.<type> helpers in mount-by-pattern tests
The test behavior is fragile if depends on external helpers. Let's
keep it based on mount(2) only. The test will be faster too.
Note that "mount -t <pattern>" does not behaviour as expected with
helpers. We need to try another helper if the current one ends with
status=1 (waitpid()). Now it returns status from the first helper.
Reported-by: Ruediger Meier <sweet_f_a@gmx.de>
Signed-off-by: Karel Zak <kzak@redhat.com>
Vaclav Dolezal [Tue, 19 Dec 2017 09:39:19 +0000 (10:39 +0100)]
libfdisk: return bytes processed from gpt_entry_set_name(), process rc
Made gpt_entry_set_name() return number of utf8 bytes processed on
success, so info message about change can be accurate.
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Vaclav Dolezal [Thu, 14 Dec 2017 14:39:42 +0000 (15:39 +0100)]
libfdisk: allocate enough bytes for ucs2 to utf8 encoding
Allocate 3*number_of_ucs2_characters bytes for utf8 output.
Also as we are using calloc there's no need to write terminating null
byte.
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Vaclav Dolezal [Wed, 20 Sep 2017 13:50:37 +0000 (15:50 +0200)]
libfdisk: gpt: properly encode string on rename
GPT partition name entry should be recorded as little endian UCS2, so I have
written proper conversion (assuming UTF8 input).
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Karel Zak [Mon, 18 Dec 2017 12:57:20 +0000 (13:57 +0100)]
build-sys: don't check for swapon() number of arguments
The syscall swapon() with two arguments is supported since Linux 1.3.2
and it's really long time ago... Let's assume that all libc header files
have been already fixed.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 18 Dec 2017 12:03:46 +0000 (13:03 +0100)]
libblkid: (bcache) cleanup magic string definition
Reported-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 18 Dec 2017 11:44:03 +0000 (12:44 +0100)]
cal: fix multi-byte comment, explain in better way
On Sun, Dec 17, 2017 at 07:47:49PM -0500, J William Piggott wrote
> * it contains multi-byte characters (which is what drew me to reading it).
> * it truncates one very important piece of the formula: ". . . (mod 7)."
> * it explains the values for 'e', but there is no 'e' in the code.
> * it doesn't include a row resolving 'e' in the table, so it is not
> obvious what it relates to in the code.
> * without citing it as an external reference, the comment language is confusing.
Co-Author: J William Piggott <elseifthen@gmx.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 14 Dec 2017 14:52:57 +0000 (15:52 +0100)]
whereis: fix typo in debug message
Reported-by: Matthew White <mehw.is.me@inventati.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 14 Dec 2017 12:19:08 +0000 (13:19 +0100)]
Revert "cal: simplify leap year rule"
It was mistake, we use extra rule for date < 1752 from the beginning
and another calculations depends on this.
This reverts commit
b9bd8dc267a71611859496bff29e329868273714 .
Karel Zak [Wed, 13 Dec 2017 18:09:56 +0000 (19:09 +0100)]
cal: explain magic values for day of week calculation
Based on BERNDT E.SCHWERDTFEGER papers.
Signed-off-by: Karel Zak <kzak@redhat.com>
Masatake YAMATO [Tue, 12 Dec 2017 07:16:45 +0000 (16:16 +0900)]
fincore: fix a typo in fincore.1
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Karel Zak [Wed, 13 Dec 2017 11:57:22 +0000 (12:57 +0100)]
tests: update libsmartcols/title
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 12 Dec 2017 12:19:36 +0000 (13:19 +0100)]
libsmartcols: don't add blank padding after left aligned title
Let's use the same semantic for the title as for the last column in
the table. If aligned on left, table is not "maxout" and title padding
symbol is undefined (or blank) then keep title as short as possible.
Addresses: https://github.com/karelzak/util-linux/issues/549
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 12 Dec 2017 12:16:54 +0000 (13:16 +0100)]
sample-scols-title: add left title without padding
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 12 Dec 2017 11:09:13 +0000 (12:09 +0100)]
mcookie: properly initialize hash
This stupid mistake has been introduced by commit
46ae163a8e5dc8457f8e2828eb53db8e610af275 .
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 12 Dec 2017 10:54:08 +0000 (11:54 +0100)]
lib/md5: use ul_/UL_ prefix
The symbols names are too generic.
Addresses: https://github.com/karelzak/util-linux/issues/548
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 12 Dec 2017 10:42:28 +0000 (11:42 +0100)]
lib/sha1: fix indention
* indent -linux -psl -blf lib/sha1.c
* manually fix comments
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 12 Dec 2017 10:38:17 +0000 (11:38 +0100)]
test_sha1: update helper
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 12 Dec 2017 10:29:02 +0000 (11:29 +0100)]
lib/sha1: use ul_/UL_prefix for symbols
Unfortunately, the symbols are visible in statically compiled libuuid
and the names are too generic.
Addresses: https://github.com/karelzak/util-linux/issues/548
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 11 Dec 2017 15:03:39 +0000 (16:03 +0100)]
Merge branch '2017wk48' of https://github.com/kerolasa/lelux-utiliteetit
Sami Kerola [Sun, 10 Dec 2017 10:50:32 +0000 (10:50 +0000)]
docs: improve setarch(8) manual page
Add more information when and why one might want to use various options.
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
J William Piggott [Sat, 9 Dec 2017 23:43:29 +0000 (18:43 -0500)]
lib/timeutils.c: warn format_iso_time() overflow
Print a message when the format_iso_time() buffer is exceeded, because
there is more than one type of failure that returns -1.
Also remove the corresponding message from hwclock.c.
Signed-off-by: J William Piggott <elseifthen@gmx.com>
J William Piggott [Sat, 9 Dec 2017 20:05:38 +0000 (15:05 -0500)]
lib/timeutils.c:strxxx_iso: do not wrap tm_year
Year can wrap when adding the tm struct epoch during iso formatting:
hwclock --utc --noadjfile --predict --date '
67768034678844900 seconds'
-
2147481749 -12-31 23:59:59.000000-05:00
Patched:
hwclock --utc --noadjfile --predict --date '
67768034678844900 seconds'
2147485547 -12-31 23:59:59.000000-05:00
Comparable to date(1):
date -Ins --date '
67768034678844900 seconds'
2147485547 -12-31T23:59:59,
547886165 -0500
Note: the 'seconds' argument is relative to the current time, so
reaching this max year output is a moving target. The values shown
above were invalid one second later. They then overflow tm_year
upon conversion with localtime(3) and friends, which causes them
to return NULL indicating that an error occurred.
Signed-off-by: J William Piggott <elseifthen@gmx.com>
J William Piggott [Sat, 9 Dec 2017 19:40:05 +0000 (14:40 -0500)]
lib/timeutils.c:strxxx_iso: test conversion errors
Test for libc time conversion errors in ISO time format functions.
hwclock --utc --noadjfile --predict --date '
67768034678846520 seconds'
Segmentation fault
Patched:
hwclock --utc --noadjfile --predict --date '
67768034678846520 seconds'
hwclock: time
67768036191695381 is out of range.
Comparable to date(1):
date --date '
67768034678846520 seconds'
date: time
67768036191695384 is out of range
Signed-off-by: J William Piggott <elseifthen@gmx.com>
J William Piggott [Sat, 9 Dec 2017 19:01:33 +0000 (14:01 -0500)]
lib/timeutils.c: bug fix Segmentation fault
Use reentrant time functions to avoid sending a NULL pointer to
format_iso_time() (and to be reentrant ;). Followup commits test for
errors and tm_year wrapping (illustrated below).
hwclock --utc --noadjfile --predict --date '
67768034678849400 seconds'
Segmentation fault
Patched
hwclock --utc --noadjfile --predict --date '
67768034678849400 seconds'
-
2147481748 -01-00 00:10:46.000000-05:00
Signed-off-by: J William Piggott <elseifthen@gmx.com>
Karel Zak [Thu, 7 Dec 2017 14:08:29 +0000 (15:08 +0100)]
tests: unlocks on failed ts_scsi_debug_init
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 7 Dec 2017 13:41:49 +0000 (14:41 +0100)]
tests: don't call tests with races in --parallel
Some of the tests have a race by design (=wanted).
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 7 Dec 2017 13:41:08 +0000 (14:41 +0100)]
tests: support multiple locks
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 7 Dec 2017 11:31:41 +0000 (12:31 +0100)]
tests: add mdadm locks
Signed-off-by: Karel Zak <kzak@redhat.com>