Karel Zak [Thu, 18 Nov 2021 13:31:38 +0000 (14:31 +0100)]
findmnt: make sure all entries are in tree output
For example /proc/self/mountinfo when mounted in chroot environment
does not contain all nodes and parent-child relation is not always
possible to create.
Karel Zak [Thu, 18 Nov 2021 10:47:08 +0000 (11:47 +0100)]
libmount: (--all) continue although /proc is not mounted
Now 'mount --all' ends with error if /proc is not mounted and there is
some other entry before /proc in fstab. This commit improves this
situation and ignores all mount table related errors if the table is
empty.
This is important for situation when there is for example "/" as the
first line in fstab.
Addresses: https://github.com/util-linux/util-linux/issues/1492 Signed-off-by: Karel Zak <kzak@redhat.com>
Always set SIGCHLD handler to default, even if the caller of vipw has
set SIGCHLD to ignore. If SIGCHLD is ignored no zombie processes would
be created, which in turn could mean that kill is called with an already
recycled pid.
Also improved error message if child process fails.
Proof of Concept:
1. Compile nochld:
--
#include <signal.h>
#include <unistd.h>
int main(void) {
char *argv[] = { "vipw", NULL };
signal(SIGCHLD, SIG_IGN);
execvp("vipw", argv);
return 1;
}
--
2. Run nochld
3. Suspend child vi, which suspends vipw too:
`kill -STOP childpid`
4. Kill vi:
`kill -9 childpid`
5. You can see with ps that childpid is no zombie but disappeared
6. Bring vipw back into foreground
`fg`
7. See misleading warning message
You will get an improperly formatted warning message. Also the wake up
kill call sent SIGCONT to "childpid" which could have been assigned
to another process already.
This is definitely not a vulnerability. It would take super user
operations, at which point an attacker would have already elevated
permissions.
Karel Zak [Fri, 12 Nov 2021 14:18:22 +0000 (15:18 +0100)]
Merge branch 'nsenter-all-avoid-entering-nonexisting-ns' of https://github.com/Jongy/util-linux
* 'nsenter-all-avoid-entering-nonexisting-ns' of https://github.com/Jongy/util-linux:
nsenter: Do not try to enter nonexisting namespaces when --all is used
nsenter: Do not try to enter nonexisting namespaces when --all is used
This PR changes is_same_namespace() to is_usable_namespace(). If a namespace file
is missing for the running PID, then it is considered not usable and we do not try
to enter it.
zhenwei pi [Wed, 10 Nov 2021 03:16:42 +0000 (11:16 +0800)]
irqtop: add -c/--cpu-stat option
Since a23aecc1bf("irqtop: add per-cpu stats"), irqtop always shows
per-cpu stats. Test on a modern AMD server with 2 socket(256 CPU),
irqtop shows messy output with too many columns.
In this patch, add -c/--cpu-stat option to enable/disable per-cpu stats.
And 'auto' option auto-detect window size, only show per-cpu stats
if the length of per-cpu stats is shorter than the width of window.
[kzak@redhat.com: - shorten the commit message
- rename --cpu to --cpu-stat
- use scols_table_enable_nowrap() rather than trim in irqtop.c
- reduce --help for the new option]
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 8 Nov 2021 12:38:45 +0000 (13:38 +0100)]
libfdisk: enlarge partition by move start down
Now it's possible move start of the partition only when offset or
absolute value is specified. This commit implements resize to "use all
available free space before the current start".
We already support the same for end of the partition (resize to use all
free space after the partition).
To get it to work a secret named COVERITY_SCAN_TOKEN should
be added to the util-linux repository:
https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository
It has to match the util-linux project token, which
can be found at
https://scan.coverity.com/projects/karelzak-util-linux?tab=project_settings
Daan De Meyer [Sat, 30 Oct 2021 14:56:14 +0000 (15:56 +0100)]
login: Restore tty size after calling vhangup()
If login receives the tty to work on via stdin, stdout and stderr,
login might end up closing the remaining open file descriptors to
the tty just before it calls vhangup(). When the last open file
descriptors to a tty are closed, it's configured size is reset to
0x0. To avoid this from happening, save the size before closing
the stdin, stdout and stderr file descriptors and reapply the size
after the tty is re-opened.
Karel Zak [Mon, 25 Oct 2021 10:21:15 +0000 (12:21 +0200)]
Merge branch 'refactor-tests' of https://github.com/Ajchler/util-linux
* 'refactor-tests' of https://github.com/Ajchler/util-linux:
tests: split additional tests into subtests
tests: split several tests into subtests
tests: split test into subtest
tests: split cal/colorw test into subtests
tests: split cal/color test into subtests
Ludwig Nussel [Thu, 21 Oct 2021 13:00:59 +0000 (15:00 +0200)]
agetty: use getttynam() if available
/etc/ttys seems to be a rather archaic concept that is not meant to
exist on Linux. Nevertheless it does. glibc has getttynam() which
correctly parses /etc/ttys. So let's give it a try before falling back
to the built in defaults. One can set the terminal type for a
specific tty using e.g.:
echo 'ttyS0 "" xterm' > /etc/ttys
[kzak@redhat.com: - improve configure.ac part
- log error on failed strdup()]
Karel Zak [Thu, 21 Oct 2021 14:00:01 +0000 (16:00 +0200)]
logger: realloc buffer when header size changed
This is probably paranoid optimization, but when we generate a new
header we need to be sure that buffer is not smaller than calculated
maximal size of user's data.
mkswap: <swapfile> contains holes or other unsupported extents.
This swap file can be rejected by kernel on swap activation!
Use --verbose for more details.
[zeha@debian.org: this appears to be important/required when building
inside cowbuilder, on an ext3 filesystem.]
Karel Zak [Mon, 4 Oct 2021 09:14:01 +0000 (11:14 +0200)]
fstrim: don't trigger autofs
- ignore read-only entries
- ignore autofs entries (for example from /proc/self/mountinfo)
- ignore autofs mountpoints where automounter has not been triggered yet
Fixes: https://github.com/karelzak/util-linux/issues/1463 Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 1 Oct 2021 12:59:50 +0000 (14:59 +0200)]
su: reset RLIMIT_{NICE,RTPRIO} to zero
Addresses: https://github.com/linux-pam/linux-pam/issues/85 Reported-by: Lennart Poettering <lennart@poettering.net> Signed-off-by: Karel Zak <kzak@redhat.com>
projects / thirdparty / util-linux.git / log
