setterm: fix various color option argument lists

The lists did not have correct colors in usage().  Because the usage()
had to be fixed, it is best to make the output easy for translators to
work with.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

partx: remove deprecated option from usage()

The fact that -l, --list is deprecated will remain in manual page till
unforeseeable future.  Meanwhile the usage() can be made shorter.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lscpu: fix error message

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

losetup: allow -j option argument to be relative path

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fsfreeze: tell user when mandatory option is not specified

This commit also removes use of internal magic values by replacing them
with a enum definition.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

dmesg: fix usage() output consistancy

Possible facilities and levels are meant to be printed to same file as
the rest of the usage output.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

agetty: the command does not have -h and -V options

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

newgrp: use xstrdup to check allocation succeeded

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: remove repeated words

Signed-off-by: Karel Zak <kzak@redhat.com>

rtcwake: add --auto to usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

readprofile: reorder options in man page

Signed-off-by: Karel Zak <kzak@redhat.com>

readprofile: add --counters to the man page

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

agetty: add --chroot to usage() and man page

Signed-off-by: Karel Zak <kzak@redhat.com>

agetty: add -E, --remote to usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

ul: cleanup usage() and man page

Signed-off-by: Karel Zak <kzak@redhat.com>

raw: add long options to man page

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: add --read-write to man page

mount: add --show-labels to man page

Signed-off-by: Karel Zak <kzak@redhat.com>

setarch: normalize man page formatting

Signed-off-by: Karel Zak <kzak@redhat.com>

getopt: fix usage() typo unquote -> unquoted

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: fix typo fsroot -> nofsroot

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: use O_CLOEXEC

... to make "strace -e open blkid" for libblkid stuff without
exceptions.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use O_CLOEXEC

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: use O_CLOEXEC

Signed-off-by: Karel Zak <kzak@redhat.com>

libuuid: use O_CLOEXEC

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: use O_CLOEXEC

Signed-off-by: Karel Zak <kzak@redhat.com>

lib: use O_CLOEXEC in libcommon

Signed-off-by: Karel Zak <kzak@redhat.com>

include/fileutils: use O_CLOEXEC for mktemp stuff

Signed-off-by: Karel Zak <kzak@redhat.com>

include/c: add macro UL_CLOEXECSTR

... to make "e" for fopen() portable to systems without O_CLOEXEC.

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/canonicalize: don't use /dev/mapper/<name> if the node does not exist

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: add version and features to debug output

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: add --paths

Now it's not so simple to generate full paths to devices if you want to
use user friendly names like /dev/mapper/foo. Let's make it easy.

libmount: make mnt_table_find_* more robust [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

wipefs: make do_wipe() more readable [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

rename: fix memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

wipefs: fix memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

setterm: fix memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

mkfs.cramfs: fix resource leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

pg: fix memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: (gpt) fix memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

mkfs.cramfs: fix memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/xalloc: fix mamory leak in xgethostname() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: (udf) fix possible null pointer dereference [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: make /proc/sysinfo usage more robust [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: remove dead code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

sulogin: don't run if not found passww entry [coverity scan]

sulogin(8) should not run if there is no /etc/{passwd,shadow} entry
and --force command line option is no specified otherwise NULL pointer
dereference is possible.

Signed-off-by: Karel Zak <kzak@redhat.com>

flock: possible pointer dereferences [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

getopt: fix normalize() usage [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

su: make code more robust [coverity scan]

 ... and more readable for static analyzers

Signed-off-by: Karel Zak <kzak@redhat.com>

agetty: make \{4,6} issue file code more robust [coverity scan]

 ... and more readable for static analyzers

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix __mnt_optstr_append_option() nonull attribute [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix __mnt_cache_find_tag_value() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: fix hctl buffer usage [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: check returns [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

login: check returns [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: check returns [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: check returns [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck.cramfs: check returns [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix NTFS prober on big-endian machines

 MFT_RECORD_ATTR_VOLUME_NAME  = cpu_to_le32(0x60),
                                 ^
./include/bitops.h:94:36: error: braced-group within expression
allowed only inside a function

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix user-mount by root for mount.<type> helpers

Append options like "exec" "suid" and "dev" to mount.<type> helpers
command line if the options are in fstab. This is relevant for root
user who calls mount(8) for fstab entries with "user,exec" etc.

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add note about /var/lib/hwclock to TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

schedutils: don't apply -a without -p

The unsuspecting user might use taskset -a mask command. Behavior then
is to exec with no affinity applied at all. Better handled by ignoring
all_tasks if no pid was given.

Signed-off-by: Daniel Stodden <daniel.stodden@gmail.com>

rtcwake: clean up usage

Signed-off-by: Karel Zak <kzak@redhat.com>

include/pathnames: rename _PATH_ADJPATH to _PATH_ADJTIME

Signed-off-by: Karel Zak <kzak@redhat.com>

rtcwake: add --adjfile command line option

 ... for better compatibility with hwclock.

Signed-off-by: Karel Zak <kzak@redhat.com>

sulogin: couple of obvious fixes for non-linux systems

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: arch is gone, use delpart as usage() function example

The arch.c was removed in commit 27abd809.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

blkid: use xalloc.h when possible

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mount: improve --move error message on shared trees

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: add mnt_table_find_mountpoint()

This is more robust implementation of mnt_get_mountpoint() that does
not ignore bind mountpoints (mount --bind /mnt /mnt) as it does not
depend on st_dev numbers.

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: make libmount.h consistent with code

The function with nonnull attribute are silently optimized by gcc so
all "if (foo)" are removed if the "foo" is expected as non-null. It
make the code less usable and robust in some situations.

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: umount crashes when trying to umount a non-mountpoint

Reported-by: Mantas Mikulėnas <grawity@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: release++ (v2.23-rc1)

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: keep libuser optional

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: upadte v2.23-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add v2.23-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: fix typos in man page

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: add hr.po (from translationproject.org)

po: update vi.po (from translationproject.org)

po: update fr.po (from translationproject.org)

po: update cs.po (from translationproject.org)

tests: update build tests

 * remove ld-linux-* from output
 * findmnt linked with libudev
 * lslocks linked with libmount
 * uuidd linked with librt
 * static binaries are no more enabled by default
 * chfn/chsh linked with libuser
 * add nsenter, runuser, setpriv

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add chfnsh build tests

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: set dependence fdisk -> libfdisk -> libuuid

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: lslocks depends on libmount

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: don't use libs from pkg-config from libuser

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: don't use nested BUILD_*

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: cleanup _() usage in synchronize_to_clock_tick_rtc()

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: don't confuse users with select() timeout warning

Reported-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

raw: fix "Error setting raw device: Success"

 # raw /dev/raw/raw1 253 40
 raw: Error setting raw device:Success

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=923820
Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: remove unwanted operator [smatch scan]

Reported-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

ipcs: fix compiler warning [clang -Wuninitialized]

Signed-off-by: Karel Zak <kzak@redhat.com>

script: use __noreturn__ for really last function [clang -Winvalid-noreturn]

Use 'noreturn' for done() only.

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: check for security_get_initial_context()

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: (gpt) rmeove xalloc calls

Signed-off-by: Karel Zak <kzak@redhat.com>

remove duplicate includes

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add AVAILABILITY section to isosize man page, and tweak wording

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>