login-utils: verify writing to streams was successful

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

misc-utils: verify writing to streams was successful

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mount: verify writing to streams was successful

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

partx: verify writing to streams was successful

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

schedutils: verify writing to streams was successful

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

sys-utils: verify writing to streams was successful

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

term-utils: verify writing to streams was successful

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

text-utils: verify writing to streams was successful

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

include: add stream error checking facility

The close_stream() is copied from GNU lib.  Inspiration to do this is
talk by Jim Meyering - Goodbye World! The perils of relying on output
streams in C.

Reference: http://www.irill.org/events/ghm-gnu-hackers-meeting/videos/jim-meyering-goodbye-world-the-perils-of-relying-on-output-streams-in-c
Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lsblk: count with terminating character, man page -s entry

Signed-off-by: Peter Rajnoha <prajnoha@redhat.com>

build-sys: disable chkdupexe by default, mark as deprecated

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: use libmount to get mountpoints/swaps

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: add support to parse /proc/swaps

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: clean up MNT_FMT_* usage in parser

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: (old) check for LD_FLAGS_AUTOCLEAR more carefully

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=803799
Signed-off-by: Karel Zak <kzak@redhat.com>

lib/loopdev: more robust initialization

Signed-off-by: Karel Zak <kzak@redhat.com>

rtcwake: tiny coding style change

Signed-off-by: Karel Zak <kzak@redhat.com>

script: error in usage() output

Error originates to commit 3ff526391fb5c6b33418dc9cfec31c2ff9b4792e
which is bit more than year, and part or releases v2.20 & v2.21.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tests: hwclock: locate ntpdate by using path

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

rtcwake: only invoke RTC_AIE_ON/OFF ioctls in pairs

many rtc drivers don't implement the RTC_AIE_ON/OFF ioctls at all --
so if we never tried to enable the alarm interrupt, don't try to
disable it later.

Signed-off-by: Paul Fox <pgf@laptop.org>

delpart: improve error messages

Signed-off-by: Karel Zak <kzak@redhat.com>

addpart: improve error messages

Signed-off-by: Karel Zak <kzak@redhat.com>

tools: ko-release: make scripts bourne sh compliant [checkbashisms]

$ checkbashisms ko-release-gen
possible bashism in ko-release-gen line 31 ('function' is useless):
function die {
possible bashism in ko-release-gen line 36 ('function' is useless):
function add_file {
possible bashism in ko-release-gen line 68 ('function' is useless):
function add_html_dir {
possible bashism in ko-release-gen line 72 (brace expansion):
        for fl in $(ls $src/*.{html,css,png}); do

$ checkbashisms ko-release-push
possible bashism in ko-release-push line 29 ('function' is useless):
function die {
possible bashism in ko-release-push line 34 ('function' is useless):
function push_file {

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tools: config-gen: make scripts bourne sh compliant [checkbashisms]

$ checkbashisms config-gen
script config-gen does not appear to be a /bin/sh script
possible bashism in config-gen line 27 (export foo=bar should be foo=bar; export foo):
        export CFLAGS="$CFLAGS"
$ checkbashisms config-gen-functions.sh
possible bashism in config-gen-functions.sh line 14 ('function' is useless):

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tools: checkconfig.sh: make scripts bourne sh compliant [checkbashisms]

script checkconfig.sh does not appear to be a /bin/sh script
possible bashism in checkconfig.sh line 14 ('function' is useless):
function die() {
possible bashism in checkconfig.sh line 27 ('((' should be '$(('):
while (( "$#" )); do

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

reset: make scripts bourne sh compliant [checkbashisms]

In addition strict compliance the commit will take variable name
quoting, and $(command) substitution in use.

$ checkbashisms reset reset.033c
possible bashism in reset line 11 ('$[' should be '$(('):
bot=$[ ${LINES:-`tput lines`} - 1 ]
possible bashism in reset.033c line 11 (echo -e):
echo -e \\033c

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fstrim: add --version and align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

findmnt: remove dublicate usage() line

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fallocate: add --version and align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

swaplabel: add --version and align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fsck.minix: fix printf format warning

fsck.minix.c:1302:3: warning: ISO C does not support the '%m' gnu_printf format [-Wformat]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fsck.minix: clean up coding style

$ indent -linux -psl -blf disk-utils/fsck.minix.c

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fsck.minix: align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fsck.minix: use rpmatch() for yes/no question

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fsck.minix: use symbolic exit codes

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fsck.cramfs: add long options

And align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

pg: align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

pg: correct version printing in help screen

Commit also adds -V option.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

raw: clean up coding style

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

raw: check numeric user inputs

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

raw: use pathnames.h for file locations

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

raw: use libc error printing facilities

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

raw: use symbolic exit numbers

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

raw: add long options and version printing

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

raw: align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

delpart: align with util-linux coding standards

Add long options and usage function, use gnu errror printing
facilities and validate inputs.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

addpart: align with util-linux coding standards

Add long options and usage function, use gnu errror printing
facilities and validate inputs.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

partx: add --version option

Th commit 8275b7326e535c6d745414baca680f03e9eccdf3 added --version to
usage() but not as working option.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

setterm: correct manual page reference

An error from commit faa0548de47df5691cf56dd49daaba8dbc89d34a

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

findfs: add --version & align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

findmnt: add --version & align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mountpoint: add --version & align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

hexdump: use strtosize_or_err()

Signed-off-by: Karel Zak <kzak@redhat.com>

losetup: use strtosize_or_err()

Signed-off-by: Karel Zak <kzak@redhat.com>

fstrim: use strtosize_or_err()

Signed-off-by: Karel Zak <kzak@redhat.com>

wipefs: use strtosize_or_err()

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: use strtosize_or_err()

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/strutils: add strtosize_or_err, clean up

 * add strtosize_or_err(), we use strtosize() + err() on many places

 * add STRTOXX_EXIT_CODE to overwrite the default EXIT_FAILURE

 * remove else-after-noreturn (e.g. if (foo) err(...); else err(...))

 * clean up indent...

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: clarify KiB vs. KB in man pages

Update the man pages of blkid, wipefs, fallocate, fstrim, losetup
and hexdump to clarify the suffixes for the numerical values of the
offset and size/length arguments regarding KiB=1024 vs KB=1000.
Also mention the ZiB/YiB and ZB/YB suffixes supported by strtosize().

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>

tools: improve ko-release-* scripts

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: add note about variable tags and devices order.

Reported-by: Michael Conrad <mconrad@intellitree.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move obsolete lib/fsprobe to mount/

Signed-off-by: Karel Zak <kzak@redhat.com>

swapon: use directly blkid rather than fsprobe wrapper

 * remove dependence on lib/fsprobe.c

 * reuse already read swap header for --fixpgsz (don't re-read the
   header by libblkid)

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add swapon tests for --fixpgsz and fix signature

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: mark udev and list blkid(8) output formats deprecated

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: update

Signed-off-by: Karel Zak <kzak@redhat.com>

Revert "lib/canonicalize: always remove tailing slash"

It's overkill to modify unknown paths in a generic function like
canonicalize_path().

for example:

 mount -t fuse 'sshfs#marty@thee:/' /media/thee

will be canonicalized to

 mount -t fuse 'sshfs#marty@thee:' /media/thee

and this obvious bug.

Reported-by: Martin Panter <vadmium+floss@gmail.com>
This reverts commit 28074a0952469aebf021821d95238cfb964d13ff.

hexdump: update man page for -n and -s

Reported-by: Bernhard Voelker <mail@bernhard-voelker.de>
Signed-off-by: Karel Zak <kzak@redhat.com>

tests: update iso tests

Signed-off-by: Karel Zak <kzak@redhat.com>

hexdump: use strtosize() for -n and -s

strtosize() is based on uintmax_t and supports all possible suffixes
(B,M,G,T ...)

Reported-by: Simon de Vlieger <simon@ikanobori.jp>
Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: generate pseudo-UUID for ISO9660 image file

The UUID is generated from the modification date in the ISO volume
descriptor. As GRUB 2 is using this definition for the pseudo UUID for
ISO9660 files libblkid would be perfectly compatible with GRUB 2.

Signed-off-by: Andreas Vogel <Andreas.Vogel@anvo-it.de>
Signed-off-by: Karel Zak <kzak@redhat.com>

mount: fix recursively propagation mounting

Provide the recursive flag of propagation mounting. Recursive flag could
be used together with propagation flag.

[kzak@redhat.com: - add MS_SILENT to acceptable propagation flags,
                  - fix new code in libmount too]

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Dong Hao <haodong@linux.vnet.ibm.com>

fsck: tiny coding style fix

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: use gettimeofday() for real elapsed time statistic

 and use shorter "rss" rather than "maxrss" keyword in stats output

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: Add a -r option to report memory and runtime statistics

This patch adds a "-r" option to report statistics for each fsck run.
It gathers the statistics via wait4() and rusage and reports exit
status, system and user CPU time, elapsed wall-clock time and the max
RSS.

[kzak@redhat.com: - rebase to the latest code,
                  - report all on one line,
                  - use "real" rather than "elapsed"]

Signed-off-by: Frank Mayhar <fmayhar@google.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: move to disk-utils directory

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: coding stype fixes (calloc, err, ...)

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: don't try to call fsck for undefined fs type

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: fix coding style

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: remove unnecessary fsck.h

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: use libmount to check for mounted filesystems

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: improve mnt_tables_is_mounted

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: remove string_copy()

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: replace fsprobe with libmount utils

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: use libmount for filesystem list

libmount provides all necessary functionality required in fsck for
work with filesystems descriptions.

This patch seems large and invasive, because removes fsck_fs struct,
changes:

  - use libmnt to parse fstab
  - use libmnt_fs from libmount
  - replace "fs->" with mnt_fs_* or fs_* functions

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: don't duplicate exit code macros

Signed-off-by: Karel Zak <kzak@redhat.com>

include/exitcodes: clean up names, add _EX_ suffix

Signed-off-by: Karel Zak <kzak@redhat.com>

include/exitcodes: add FSCK_DESTRUCT alias

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: cosmetic changes in coding style

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: don't print confusing warning on non-partitioned disks

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=740163
Signed-off-by: Karel Zak <kzak@redhat.com>

misc: clenaup SIZE columns in lsblk and findmnt

Note that lib/tt.c will never truncate columns without TT_FL_TRUNC or
relative column width. So it's fine to set small width for columns
with SIZEs, the defined width is minimal width.

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: improve --df output

 * don't print pseudo-filesystems (except tmpfs)
 * add --all to disable built-in filters
 * don't overwrite --df --output=<list> with default columns

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: add configfs to pseudofs list

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/tt: work more sensitive with large columns

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: use xasprintf()

Signed-off-by: Karel Zak <kzak@redhat.com>

include/ttyutils.h: add include guards

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

findmnt: add -D, --df option to imitate df(1)

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

tunelp: remove old, now unneeded header

malloc and friends are provided by stdlib.h.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

findmnt: add FS size, avail, used, and use% columns

Provide display of filesystem attributes from statvfs(3). These are all
displayed in human readable format.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

checkxalloc: nudge regex, fix newfound instances

Using the -w flag with grep actually fought against us here, and hid
some instances where xalloc functions weren't used. Discard it in
favor of an explicit word boundary as a prefix to the function name,
and extend our requirements on the trailing side of the pattern.

This also fixes the few new instances that were overlooked because of
the regex's deficiency.

[kzak@redhat.com: - fix also newfound in findmnt
                  - remove unnecessary checks after xallocs]

Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>