]>
git.ipfire.org Git - thirdparty/util-linux.git/log
Sami Kerola [Sat, 17 Sep 2011 19:28:12 +0000 (21:28 +0200)]
docs: align vipw.8 with howto-man-page.txt
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 17 Sep 2011 19:11:51 +0000 (21:11 +0200)]
docs: fix return value table in fsck.8
Commint also has few alignments with howto-man-page.txt
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 17 Sep 2011 18:46:34 +0000 (20:46 +0200)]
docs: chcpu and readprofile are sysadmin utils
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Karel Zak [Thu, 29 Sep 2011 18:50:27 +0000 (20:50 +0200)]
tests: add loopdev libmount test
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 29 Sep 2011 18:50:08 +0000 (20:50 +0200)]
libmount: support {offset,sizelimit}= foor loopdevs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 29 Sep 2011 15:48:03 +0000 (17:48 +0200)]
libmount: add function to parse offsets/sizes
Francesco Cosoleto [Wed, 28 Sep 2011 14:25:31 +0000 (16:25 +0200)]
ipcrm: fix wrong subject in error messages for -m, -q, -s id options
This makes error messages print 'id' instead of 'key' using id options.
Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
Francesco Cosoleto [Wed, 28 Sep 2011 14:25:30 +0000 (16:25 +0200)]
ipcrm: use ternary operator in "(key|id) failed" message
Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
Francesco Cosoleto [Wed, 28 Sep 2011 14:25:29 +0000 (16:25 +0200)]
ipcrm: add static keyword to some functions
Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
Petr Uzel [Thu, 22 Sep 2011 10:12:37 +0000 (12:12 +0200)]
misc: use %m in format string instead of %s and strerror(errno)
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Thu, 22 Sep 2011 10:12:08 +0000 (12:12 +0200)]
docs: update TODO
TODO items already done by Sami Kerola
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Mon, 19 Sep 2011 13:29:15 +0000 (15:29 +0200)]
sfdisk: warn if partition exceeds partition table limits
Warn the user if the partition to be created exceeds limits
imposed by the DOS partition table, which is:
* partition has to start on sector < 2^32
* partition size has to be < 2^32 sectors
For 512-byte logical sector size, these limits are ~2.2 TiB.
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Mon, 19 Sep 2011 13:29:14 +0000 (15:29 +0200)]
sfdisk: use unsigned long long to internally represent sector number
Unsigned long is only 4 bytes long on i586, which is not enough to
represent sector number on todays large disks. Use unsigned long long,
which is 8 bytes long, to store the sector numbers internally, so that
we could later make some sanity checks and warn the user if the sector
numbers exceed the limits imposed by DOS partition table format.
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Mon, 19 Sep 2011 13:29:13 +0000 (15:29 +0200)]
sfdisk: introduce get_ull() function
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Mon, 19 Sep 2011 13:29:12 +0000 (15:29 +0200)]
sfdisk: get_disksize() returns long long
unsigned long is 4 bytes long on i586, which is not enough for big
HDD's with 512B sectors. Use unsigned long long, which is 8 bytes.
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Mon, 19 Sep 2011 13:29:11 +0000 (15:29 +0200)]
sfdisk: make the cylinder boundary check less fatal
If the specified format is not cylinders, make the cylinder boundary
check only print a warning and proceed anyways.
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Mon, 19 Sep 2011 13:29:10 +0000 (15:29 +0200)]
sfdisk: fix weird indentation in msdos_partition()
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Mon, 19 Sep 2011 13:29:09 +0000 (15:29 +0200)]
sfdisk: file descriptor is of int type
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Dave Reisner [Sat, 17 Sep 2011 21:20:47 +0000 (17:20 -0400)]
blkid: fix unfinished sentence for -l option in blkid.8
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Eric Sandeen [Sat, 17 Sep 2011 00:53:50 +0000 (19:53 -0500)]
uuidd: Add missing break to option case statement
Specifying the "-n" option to uuidd would incorrectly
fall through to the "-p" case, and assign that number to
the pidfile_path.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Francesco Cosoleto [Thu, 15 Sep 2011 14:17:46 +0000 (16:17 +0200)]
libmount: fix use of logical '&&' with constant operand
Found by clang.
Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
Francesco Cosoleto [Thu, 15 Sep 2011 14:17:45 +0000 (16:17 +0200)]
lib,loopdev: fix use of logical '&&' with constant operand
Found by clang.
Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
Petr Uzel [Thu, 15 Sep 2011 08:19:17 +0000 (10:19 +0200)]
flock: make flock(1) work on NFSv4
To pleace an exclusive lock on a file, NFSv4 requires
the file to be opened RW because of the emulation of flock()
by fcntl():
http://www.spinics.net/lists/linux-nfs/msg18502.html
So instead of O_RDONLY, open the file in O_RDWR if access()
indicates it is possible (unless shared lock is requested).
From: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Karel Zak [Tue, 27 Sep 2011 12:59:57 +0000 (14:59 +0200)]
build-sys: add path.h to Makefile.am
Signed-off-by: Karel Zak <kzak@redhat.com>
Heiko Carstens [Thu, 15 Sep 2011 06:52:34 +0000 (08:52 +0200)]
lscpu: stricter command line parsing
Disallow superfluous commands for lscpu like e.g. "lscpu bla" and let it
fail print the help text instead.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Thu, 15 Sep 2011 06:52:33 +0000 (08:52 +0200)]
lscpu: add --offline option
Implement "--offline" option which only prints offline cpus. As a side effect
we can get rid of the internal "allcpus" flag, since if we want to print
informations for online and offline cpus we simply set both flags.
When reading sysfs attributes of cpus this is now done for all cpus, since
e.g. the topology informations of the online cpus may influence the
topology informations of the offline cpus. This mainly because online cpus
may contain masks which include offline cpus while offline cpus have a
missing topology directory.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Thu, 15 Sep 2011 06:52:32 +0000 (08:52 +0200)]
lscpu: fix -e output
The modifier mod->allcpus must be set earlier and also must be used
earlier. The current code only reads sysfs attributes from online
cpus but skips offline cpus.
So initialize mod->allcpus earlier.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Thu, 15 Sep 2011 06:52:31 +0000 (08:52 +0200)]
chcpu: provide better user feedback
Instead of printing error messages like "I/O resource busy" which are
supplied by strerror, give better feedback if the reason of failure
is known.
E.g. taking the last cpu offline cannot succeed, therefore print a
message that gives this "hint".
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Fri, 16 Sep 2011 08:28:43 +0000 (10:28 +0200)]
lib,path: use write_all()
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Since write() doesn't necessarily write the complete buffer with
one call we better use write_all() which takes care of this.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Thu, 15 Sep 2011 06:52:30 +0000 (08:52 +0200)]
chcpu: convert to use lib/path.c
Use the common path access functions. In order to simplify chcpu also implement
and use path_writestr() which writes a string to the path specified.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Thu, 15 Sep 2011 06:52:29 +0000 (08:52 +0200)]
lib,path: move path access functions from lscpu into lib/path.c
A couple of these functions already have been copied to chcpu.c,
so it makes sense to move these functions into an own file.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Karel Zak [Tue, 27 Sep 2011 11:26:59 +0000 (13:26 +0200)]
setarch: minor changes to usage()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 27 Sep 2011 11:26:45 +0000 (13:26 +0200)]
pivot_root: minor changes to usage()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 27 Sep 2011 11:26:26 +0000 (13:26 +0200)]
ipcs: minor changes to usage()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 27 Sep 2011 11:26:06 +0000 (13:26 +0200)]
ctrlaltdel: minor changes to usage()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 27 Sep 2011 11:25:53 +0000 (13:25 +0200)]
arch: minor changes to usage()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 27 Sep 2011 10:56:48 +0000 (12:56 +0200)]
Merge branch 'sys-utils' of https://github.com/kerolasa/lelux-utiliteetit
* 'sys-utils' of https://github.com/kerolasa/lelux-utiliteetit: (29 commits)
docs: add non-return function and if shorthand tips
build-sys: fixes to USAGE_* macros
ipcrm: check IPC syscalls
ipcrm: add --verbose option
ipcmk: allow high speed ipc creation
ipcrm: add --all option
docs: add long options to ipcs.1 man page
docs: add long options to ipcrm.1 man page
docs: add long options to ipcmk.1 man page
docs: add --version to setarch.8
docs: mention long options in ctrlaltdel.8
ctrlaltdel: add version & help options
docs: mention long options in pivot_root.8
pivot_root: add version & help option
ipcs: comment & white space clean up
ipcs: include-what-you-use header check
ipcs: add long options
ipcrm: include-what-you-use header check
ipcrm: refactor new and old main to share code
ipcrm: exit if unknown error occurs
...
Davidlohr Bueso [Wed, 14 Sep 2011 18:07:06 +0000 (15:07 -0300)]
mount: use common libs
Get rid of the local xmalloc.[c/h] files by using the global xalloc and
strutils libraries.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Karel Zak [Tue, 27 Sep 2011 10:45:42 +0000 (12:45 +0200)]
lscpu: add column names to --help
* use uppercase by default (only -p uses lowercase)
* a little cleanup usage()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 27 Sep 2011 10:26:02 +0000 (12:26 +0200)]
lscpu: gettextize two columns
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 26 Sep 2011 10:34:10 +0000 (12:34 +0200)]
agetty: test ECHO on c_lflag
Reported-by: xinglp <xinglp@gmail.com>
Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=739522
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Sat, 17 Sep 2011 12:35:15 +0000 (14:35 +0200)]
docs: add non-return function and if shorthand tips
Non-return functions should not be combined with `else' clause.
The if shorthands `var = e ? t : f;' need to fit to single line,
and if that does not look good use normal "if else" syntax.
Both tips are mentioned in email bellow.
http://www.spinics.net/lists/util-linux-ng/msg05152.html
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 17 Sep 2011 10:52:32 +0000 (12:52 +0200)]
build-sys: fixes to USAGE_* macros
The USAGE_BEGIN_TAIL is removed as unnecessary.
In between command specific options and --help & --version
USAGE_SEPARATOR is inserted. For now the separator is empty line.
The USAGE_MAN_TAIL is changed to take an argument.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Davidlohr Bueso [Wed, 14 Sep 2011 17:02:15 +0000 (14:02 -0300)]
ipcrm: check IPC syscalls
It's not enough to check errno for errors as the variable is not
reset, we also need to check the last syscall return value to
verify a problem. This addresses bogus msgqueue errors when
deleting keys.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 13 Sep 2011 20:00:13 +0000 (22:00 +0200)]
ipcrm: add --verbose option
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 12 Sep 2011 20:01:03 +0000 (22:01 +0200)]
ipcmk: allow high speed ipc creation
This commit will allow user to create quickly plenty of ipc
resources. Earlier the line bellow gave no satisfaction.
for i in $(seq 0 42); do ipcmk -Q; done
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 12 Sep 2011 16:56:30 +0000 (18:56 +0200)]
ipcrm: add --all option
An --all option will remove all ipc entries. The option takes
optional resource argument, which limits the removal to be
applied only the given resource entries.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 5 Sep 2011 20:05:37 +0000 (22:05 +0200)]
docs: add long options to ipcs.1 man page
Includes few style fixes from Documentation/howto-man-page.txt
and align information by what is being said by The Open Group.
http://pubs.opengroup.org/onlinepubs/
009604599 /utilities/ipcs.html
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 5 Sep 2011 19:29:54 +0000 (21:29 +0200)]
docs: add long options to ipcrm.1 man page
Includes few style fixes from Documentation/howto-man-page.txt
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 5 Sep 2011 19:16:08 +0000 (21:16 +0200)]
docs: add long options to ipcmk.1 man page
Includes few style fixes from Documentation/howto-man-page.txt
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 5 Sep 2011 18:56:30 +0000 (20:56 +0200)]
docs: add --version to setarch.8
Includes few style fixes from Documentation/howto-man-page.txt
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Wed, 31 Aug 2011 18:59:48 +0000 (20:59 +0200)]
docs: mention long options in ctrlaltdel.8
Includes other manual page maintenance fixes.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Wed, 31 Aug 2011 18:52:01 +0000 (20:52 +0200)]
ctrlaltdel: add version & help options
Including other necessary changes to usage().
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Wed, 31 Aug 2011 18:37:29 +0000 (20:37 +0200)]
docs: mention long options in pivot_root.8
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Wed, 31 Aug 2011 18:33:27 +0000 (20:33 +0200)]
pivot_root: add version & help option
Including other necessary changes to usage().
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 29 Aug 2011 19:47:36 +0000 (21:47 +0200)]
ipcs: comment & white space clean up
Add to multiline comments to have left side stars, convert spaces
to tabs and indent preprocessor directives
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 29 Aug 2011 19:34:48 +0000 (21:34 +0200)]
ipcs: include-what-you-use header check
Two includes added & a sort to alphabetical order.
ipcs.c should add these lines:
#include <features.h> // for __GLIBC__
#include <stddef.h> // for size_t
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 29 Aug 2011 19:15:36 +0000 (21:15 +0200)]
ipcs: add long options
Includes necessary usage() changes.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Mon, 29 Aug 2011 18:12:41 +0000 (20:12 +0200)]
ipcrm: include-what-you-use header check
Three removes & a sort to alphabetical order.
ipcrm.c should remove these lines:
- #include <ctype.h> // lines 29-29
- #include <sys/types.h> // lines 18-18
- #include <unistd.h> // lines 27-27
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 18:24:07 +0000 (20:24 +0200)]
ipcrm: refactor new and old main to share code
The code is now much more tidy, and as a bonus old main has
shares error printing with the `new' code.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 17:01:56 +0000 (19:01 +0200)]
ipcrm: exit if unknown error occurs
Previously for instance lack of memory space caused unknown
reason to be printed, and ipcrm tried to continue.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Karel Zak [Tue, 13 Sep 2011 20:59:39 +0000 (22:59 +0200)]
mount: check for target before source on remount
Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=737091
Reported-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Petr Uzel [Tue, 13 Sep 2011 09:08:46 +0000 (11:08 +0200)]
lib: do not attempt to close(0) in sysfs_deinit()
If the 'open' fails we 'goto err' which runs 'sysfs_deinit()' on a 'cxt'
which hasn't been fully initialised. The 'dir_fd' is still 0, so
sysfs_deinit calls "close(0)".
Addresses: https://bugzilla.novell.com/show_bug.cgi?id=714151
Reported-by: Diego Ercolani <diego.ercolani@gmail.com>
Analysed-by: Neil Brown <nfbrown@suse.com>
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Karel Zak [Tue, 13 Sep 2011 09:21:47 +0000 (11:21 +0200)]
chfn: remove non-ANSI definitions [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 13 Sep 2011 09:15:43 +0000 (11:15 +0200)]
build-sys: add err and errx to smatch no_return_funcs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 13 Sep 2011 09:10:18 +0000 (11:10 +0200)]
build-sys: add smatch data
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Sun, 28 Aug 2011 16:30:23 +0000 (18:30 +0200)]
ipcrm: add long options
With long options usage function had to be changed. The change
also takes libc error printing facilities to use, primarily to
get rid of execname & progname variables.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 11:30:36 +0000 (13:30 +0200)]
ipcmk: include-what-you-use header check
Three removes & a sort to alphabetical order.
ipcmk.c should remove these lines:
- #include <string.h> // lines 24-24
- #include <sys/types.h> // lines 30-30
- #include <unistd.h> // lines 29-29
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 11:24:32 +0000 (13:24 +0200)]
ipcmk: remove camel casing
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 11:16:23 +0000 (13:16 +0200)]
ipcmk: validate numeric option arguments
Use strtoul_or_err() instead of atoi().
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 11:09:03 +0000 (13:09 +0200)]
ipcmk: remove useless code
Checking same return value twice does not make command any
better. Secondly the program_invocation_short_name is known to
work, so global progname variable does not add anything extra.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 10:39:59 +0000 (12:39 +0200)]
ipcmk: add long options & fix usage()
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Karel Zak [Mon, 12 Sep 2011 14:18:16 +0000 (16:18 +0200)]
script: non-ANSI definition [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 14:15:19 +0000 (16:15 +0200)]
whereis: non-ANSI definition [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 14:13:58 +0000 (16:13 +0200)]
logger: non-ANSI definition [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 14:12:45 +0000 (16:12 +0200)]
cal: non-ANSI definition [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 14:10:45 +0000 (16:10 +0200)]
blkid: potential null derefence [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 14:01:42 +0000 (16:01 +0200)]
libmount: previously assumed null pointer [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 13:40:24 +0000 (15:40 +0200)]
kill: potential null derefence [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 13:35:33 +0000 (15:35 +0200)]
libmount: potential null derefence [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 13:33:04 +0000 (15:33 +0200)]
libmount: variable dereferenced before check [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 13:32:35 +0000 (15:32 +0200)]
libmount: redundant null check on calling free() [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 13:28:42 +0000 (15:28 +0200)]
libmount: use unsigned int for bitfields [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 13:22:51 +0000 (15:22 +0200)]
libblkid: remove unnecessary position check from list_for_each_safe loops
The position pointer is dereferenced before the check in the
for() in the list_for_each_safe macro.
Note that struct list_head should not contain NULL pointers. See
INIT_LIST_HEAD() macro.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 12:46:35 +0000 (14:46 +0200)]
build-sys: don't use full paths for smatch
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 12:24:27 +0000 (14:24 +0200)]
agetty: add --nohints
Reported-by: "Gabor Z. Papp" <gzp@papp.hu>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 12:12:43 +0000 (14:12 +0200)]
build-sys: use --enable-most-builds for distcheck
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 11:53:10 +0000 (13:53 +0200)]
include,c.h: include fcntl.h before check for O_CLOEXEC [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 12 Sep 2011 11:52:14 +0000 (13:52 +0200)]
build-sys: add checksmatch target
Heiko Carstens [Sun, 11 Sep 2011 06:23:35 +0000 (08:23 +0200)]
lscpu: remove unneeded file
As noted by Sami I accidentally added a garbage file.
Just remove it again.
Cc: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Francesco Cosoleto [Sat, 10 Sep 2011 17:06:09 +0000 (19:06 +0200)]
fdformat: fix uninitialized variable
Spotted by EKOPath compiler.
Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
Karel Zak [Mon, 12 Sep 2011 10:42:46 +0000 (12:42 +0200)]
Merge branch 'smatch' of https://github.com/kerolasa/lelux-utiliteetit
* 'smatch' of https://github.com/kerolasa/lelux-utiliteetit:
kill: fix issue warned by smatch
last: fix smatch warning
libblkid: fix smatch warning
column: fix error reported by smatch
build-sys: ddate typo fixed
build-sys: add --enable-most-builds
Heiko Carstens [Sat, 10 Sep 2011 10:25:04 +0000 (12:25 +0200)]
lscpu: s/Y/Yes/ s/N/No/
However I'd like to see one change if you don't object: printing just "N" or
"Y" instead of "No" and "Yes" in the human readable output looks a bit ugly to
me.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Sami Kerola [Sun, 28 Aug 2011 10:04:15 +0000 (12:04 +0200)]
setarch: add version printing
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 10:01:51 +0000 (12:01 +0200)]
setarch: use program_invocation_short_name
Trust that the c.h is setting program name correctly.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sun, 28 Aug 2011 10:01:09 +0000 (12:01 +0200)]
setarch: move options struct to function scope
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 10 Sep 2011 14:50:47 +0000 (16:50 +0200)]
kill: fix issue warned by smatch
misc-utils/procs.c +82 get_pids(52) error: potential null derefence 'pids'.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 10 Sep 2011 14:49:58 +0000 (16:49 +0200)]
last: fix smatch warning
login-utils/last.c +447 ttyconv(11) error: buffer overflow '(arg)' 3 <= 3
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 10 Sep 2011 14:49:03 +0000 (16:49 +0200)]
libblkid: fix smatch warning
libblkid/src/probe.c +798 blkid_probe_get_idmag(32) error: we previously assumed 'id' could be null.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 10 Sep 2011 14:48:12 +0000 (16:48 +0200)]
column: fix error reported by smatch
column.c:201:2: error: 'for' loop initial declarations are only allowed in C99 mode
Signed-off-by: Sami Kerola <kerolasa@iki.fi>