Dave Reisner [Mon, 10 Oct 2011 23:14:15 +0000 (19:14 -0400)]
mountpoint: refactor exit path
There's only one condition for which we declare success, but many for
failure. Initialize rc as failure and set to success on this single
condition. In all cases, jump to a label to exit instead of exiting
immediately. This will be used later on to ease cleanup of any heap
allocations.
Signed-off-by: Dave Reisner <dreisner@archlinux.org> Signed-off-by: Karel Zak <kzak@redhat.com>
Dave Reisner [Sun, 9 Oct 2011 03:31:50 +0000 (23:31 -0400)]
mountpoint: return dev_t from dir_to_device
The string returned from this function was never of much use other than
to stat the path when the user requested a major:minor pair beyond the
true/false exit. Save some processing and directly returning the dev_t
on success, and an impossible value on failure.
[kzak@redhat.com: - use 0 as dir_to_device() return value on failure]
Signed-off-by: Dave Reisner <dreisner@archlinux.org> Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Sat, 1 Oct 2011 13:33:53 +0000 (15:33 +0200)]
build-sys: check scanf %ms modifier
Without the check libmount builds on systems that has older than 2.7
glibc are silently unsuccessful. The missing %ms modifier will, at
least, result on such system missing output of findmnt and lsblk
commands. If either %ms or %as modifiers are present the libmount
build is disabled.
Based on patch from: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Sat, 1 Oct 2011 11:58:51 +0000 (13:58 +0200)]
build-sys: rename BUILD_BUG_ON_ZERO definition
Definition name is changed to UL_BUILD_BUG_ON_ZERO to avoid collision
with a system header.
../include/c.h:72:1: warning: "BUILD_BUG_ON_ZERO" redefined
In file included from /usr/include/sys/sysinfo.h:25,
from dmesg.c:16:
/usr/include/linux/kernel.h:34:1: warning: this is the location of the previous definition
Karel Zak [Mon, 10 Oct 2011 11:27:40 +0000 (13:27 +0200)]
Merge branch 'manuals' of https://github.com/kerolasa/lelux-utiliteetit
* 'manuals' of https://github.com/kerolasa/lelux-utiliteetit:
docs: align hexdump.1 with howto-man-page.txt
docs: align ul.1 with howto-man-page.txt
docs: align rev.1 with howto-man-page.txt
docs: align more.1 with howto-man-page.txt
docs: align colrm.1 with howto-man-page.txt
docs: align colcrt.1 with howto-man-page.txt
docs: align col.1 with howto-man-page.txt
docs: align wall.1 with howto-man-page.txt
docs: align scriptreplay.1 with howto-man-page.txt
docs: align script.1 with howto-man-page.txt
docs: align renice.1 with howto-man-page.txt
docs: align logger.1 with howto-man-page.txt
docs: align vipw.8 with howto-man-page.txt
docs: fix return value table in fsck.8
docs: chcpu and readprofile are sysadmin utils
Karel Zak [Mon, 3 Oct 2011 13:40:15 +0000 (15:40 +0200)]
Merge branch 'sys-utils-again' of https://github.com/kerolasa/lelux-utiliteetit
* 'sys-utils-again' of https://github.com/kerolasa/lelux-utiliteetit:
cytune: fix printf type warning
docs: mention long options in cytune.8
cytune: coding style fixes
cytune: refactor main(), new function query_tty_stats()
cytune: use libc error printing facilities
cytune: check numeric user inputs
cytune: add long options and usage()
docs: restructure flock.1 manual page
flock: simplify strtotimeval()
lib: [strutils] add strtod_or_err() function
flock: use strutils.h to check numeric user input
flock: use sysexit.h for all exit values
flock: use function attributes
flock: align with howto-usage-function.txt
flock: use libc error printing facilities
flock: move long_options struct to function scope
flock: fix coding style
docs: align fallocate.1 with howto-man-page.txt
Sami Kerola [Wed, 21 Sep 2011 19:15:53 +0000 (21:15 +0200)]
flock: use libc error printing facilities
Retire global progname variable and use warn{,x} and err{,x}
functions. As a side effect of using err function the occurences of
err variable had to be converted to referrals to errno variable.
Petr Uzel [Mon, 19 Sep 2011 13:29:15 +0000 (15:29 +0200)]
sfdisk: warn if partition exceeds partition table limits
Warn the user if the partition to be created exceeds limits
imposed by the DOS partition table, which is:
* partition has to start on sector < 2^32
* partition size has to be < 2^32 sectors
For 512-byte logical sector size, these limits are ~2.2 TiB.
Petr Uzel [Mon, 19 Sep 2011 13:29:14 +0000 (15:29 +0200)]
sfdisk: use unsigned long long to internally represent sector number
Unsigned long is only 4 bytes long on i586, which is not enough to
represent sector number on todays large disks. Use unsigned long long,
which is 8 bytes long, to store the sector numbers internally, so that
we could later make some sanity checks and warn the user if the sector
numbers exceed the limits imposed by DOS partition table format.
Implement "--offline" option which only prints offline cpus. As a side effect
we can get rid of the internal "allcpus" flag, since if we want to print
informations for online and offline cpus we simply set both flags.
When reading sysfs attributes of cpus this is now done for all cpus, since
e.g. the topology informations of the online cpus may influence the
topology informations of the offline cpus. This mainly because online cpus
may contain masks which include offline cpus while offline cpus have a
missing topology directory.
The modifier mod->allcpus must be set earlier and also must be used
earlier. The current code only reads sysfs attributes from online
cpus but skips offline cpus.
So initialize mod->allcpus earlier.
Instead of printing error messages like "I/O resource busy" which are
supplied by strerror, give better feedback if the reason of failure
is known.
E.g. taking the last cpu offline cannot succeed, therefore print a
message that gives this "hint".
Karel Zak [Tue, 27 Sep 2011 10:56:48 +0000 (12:56 +0200)]
Merge branch 'sys-utils' of https://github.com/kerolasa/lelux-utiliteetit
* 'sys-utils' of https://github.com/kerolasa/lelux-utiliteetit: (29 commits)
docs: add non-return function and if shorthand tips
build-sys: fixes to USAGE_* macros
ipcrm: check IPC syscalls
ipcrm: add --verbose option
ipcmk: allow high speed ipc creation
ipcrm: add --all option
docs: add long options to ipcs.1 man page
docs: add long options to ipcrm.1 man page
docs: add long options to ipcmk.1 man page
docs: add --version to setarch.8
docs: mention long options in ctrlaltdel.8
ctrlaltdel: add version & help options
docs: mention long options in pivot_root.8
pivot_root: add version & help option
ipcs: comment & white space clean up
ipcs: include-what-you-use header check
ipcs: add long options
ipcrm: include-what-you-use header check
ipcrm: refactor new and old main to share code
ipcrm: exit if unknown error occurs
...
It's not enough to check errno for errors as the variable is not
reset, we also need to check the last syscall return value to
verify a problem. This addresses bogus msgqueue errors when
deleting keys.
Signed-off-by: Davidlohr Bueso <dave@gnu.org> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
projects / thirdparty / util-linux.git / log
