ldattach: add default case to switches

The warnings bellow are about impossible case, so makign abort() as
default seems correct.

ldattach.c:305:2: warning: switch missing default case [-Wswitch-default]
ldattach.c:313:2: warning: switch missing default case [-Wswitch-default]
ldattach.c:321:2: warning: switch missing default case [-Wswitch-default]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

ldattach: convert debug macro to function

warning: ISO C does not permit named variadic macros

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

ldattach: check numeric user inputs with strtol_or_err

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

ldattach: align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

ldattach: fix coding style

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: add long options to readprofile.8

Additionally align with with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

readprofile: fix coding style

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

readprofile: use libc error printing facilities

This commit also changes all exit values to be symbolic.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

readprofile: add long options

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align tunelp.8 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: add long options to tunelp.8

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tunelp: add long options and align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tunelp: use libc error printing facilities

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tunelp: use symbolic exit values

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tunelp: fix coding style

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

switch_root: add nls support

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

switch_root: align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

unshare: align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

rtcwake: align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

setsid: add long options and fix coding style

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

prlimit: new command

This program uses the prlimit() system call to get and/or set resource limits
for a given process.

[kzak@redhat,com: - improve <soft:hard> parsing,
                  - use short cmdline options compatible with ulimits
                  - add --verbose mode
                  - fix gcc warnings]

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: print ID_PART_ENTRY_* for small devices

The current optimization for small devices (1.4MiB) is broken. It
checks for partition table, but if nothing is detected then details
(ID_PART_ENTRY_*) about the current partition are not gathered.

The optimization should be enabled for small *whole* disks only.

Reported-by: David Zeuthen <davidz@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

switch_root: handle /run and do not mount over existing mounts

Handle /run just like /dev, /sys and /proc

Do not mount move, if there is already something mounted on the
destination folder.

Signed-off-by: Harald Hoyer <harald@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

mount: remounting tmpfs read-write hangs (selinux)

Reported-by: Petr Pisar <ppisar@redhat.com>
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=746705
Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: unable to umount nfs shares using the force option

Reported-by: Federico Simoncelli <fsimonce@redhat.com>
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=745746
Signed-off-by: Karel Zak <kzak@redhat.com>

lib,strutils: add default value to parse_range()

This function currently sets the low or high values to 0 when the string doesn't
contain a value, like '123:' or ':123'. In order to make it more flexible, we allow it
to be passed an arbitrary value.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fstrim: fix section number in referral to manpage

Reported-by: Roeland Jansen <roeland@linux-it.nl>
Addresses: https://bugzilla.novell.com/show_bug.cgi?id=723877

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

rtcwake: fix crash (invalid free)

~ $ rtcwake -d X -s 10
*** glibc detected *** rtcwake: munmap_chunk(): invalid pointer: 0x00007fff839253c3 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x733b6)[0x7f582677a3b6]
rtcwake[0x4022d5]
/lib64/libc.so.6(__libc_start_main+0xfd)[0x7f5826725bfd]
rtcwake[0x4016b9]
======= Memory map: ========
<SNIP>

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

fdisk: don't shorten long path to disk device

Reported-by: Petr Uzel <petr.uzel@suse.cz>
Signed-off-by: Karel Zak <kzak@redhat.com>

lib,strutils: share parse_range()

This function is currently only being used by partx(8), but it's handy and
generic enough that we can use it elsewhere as well.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

include/loopdev.h: add missing function prototype

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

docs: update TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: add columns description to help, fix header for parsable output

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: man page update

Rather large man page update which adds more information.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

chcpu: man page update

Move chcpu man page to section 8 (admin commands) where it belongs.
Also update the contents of the man page.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

lscpu: add s390 kvm test case

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

lscpu: fix typo in help text

Add missing 'n' in help text for extended output line.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

lscpu: switch Yes/No output to lower case

Some people complained about the first letter of Yes/No as seen in the
online and configured column in the human readabe output being a capital
letter instead of the expected lower case letter.
So let's try to make everbody happy and convert them to lower case.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

mountpoint: support symbolic and relative paths

Reported-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

Revert "mountpoint: refactor exit path"

This change is unnecessary, we can use libmount stuff for everything.

This reverts commit b16b56ec55507b6b83e0d35e3cefeb16367f3363.

mountpoint: refactor exit path

There's only one condition for which we declare success, but many for
failure. Initialize rc as failure and set to success on this single
condition. In all cases, jump to a label to exit instead of exiting
immediately. This will be used later on to ease cleanup of any heap
allocations.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

mountpoint: fallback on stat when /proc isn't mounted

Reported-by: <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

mountpoint: return dev_t from dir_to_device

The string returned from this function was never of much use other than
to stat the path when the user requested a major:minor pair beyond the
true/false exit. Save some processing and directly returning the dev_t
on success, and an impossible value on failure.

[kzak@redhat.com: - use 0 as dir_to_device() return value on failure]

Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: inform about depencency to /sys/dev/block

The lsblk depends on /sys/dev/block/ symlinks, which appeared in
kernel 2.6.27.  Users with old, or non-sysfs configured, kernel
got ealier message

lsblk: md0: failed to initialize sysfs handler
lsblk: xvda: failed to initialize sysfs handler
[...]

that I found a little too difficult to understand.  This patch will
change the message to

lsblk: failed to access sysfs directory: /sys/dev/block: No such file or directory

and informs in manual page what could be reason to that.

[kzak@redhat.com: - use access() rather than opendir()]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: check scanf %ms modifier

Without the check libmount builds on systems that has older than 2.7
glibc are silently unsuccessful.  The missing %ms modifier will, at
least, result on such system missing output of findmnt and lsblk
commands.  If either %ms or %as modifiers are present the libmount
build is disabled.

Based on patch from: Sami Kerola <kerolasa@iki.fi>

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: rename BUILD_BUG_ON_ZERO definition

Definition name is changed to UL_BUILD_BUG_ON_ZERO to avoid collision
with a system header.

../include/c.h:72:1: warning: "BUILD_BUG_ON_ZERO" redefined
In file included from /usr/include/sys/sysinfo.h:25,
                 from dmesg.c:16:
/usr/include/linux/kernel.h:34:1: warning: this is the location of the previous definition

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

build-sys: enhance error message for missing libtoolize

The commit will will use `You must have libtool version...' message
when libtoolize is missing.  Earlier the error message less helpful.

./autogen.sh: line 59: test: =: unary operator expected

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

Merge branch 'manuals' of https://github.com/kerolasa/lelux-utiliteetit

* 'manuals' of https://github.com/kerolasa/lelux-utiliteetit:
  docs: align hexdump.1 with howto-man-page.txt
  docs: align ul.1 with howto-man-page.txt
  docs: align rev.1 with howto-man-page.txt
  docs: align more.1 with howto-man-page.txt
  docs: align colrm.1 with howto-man-page.txt
  docs: align colcrt.1 with howto-man-page.txt
  docs: align col.1 with howto-man-page.txt
  docs: align wall.1 with howto-man-page.txt
  docs: align scriptreplay.1 with howto-man-page.txt
  docs: align script.1 with howto-man-page.txt
  docs: align renice.1 with howto-man-page.txt
  docs: align logger.1 with howto-man-page.txt
  docs: align vipw.8 with howto-man-page.txt
  docs: fix return value table in fsck.8
  docs: chcpu and readprofile are sysadmin utils

docs: align hexdump.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align ul.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align rev.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align more.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align colrm.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align colcrt.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align col.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align wall.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align scriptreplay.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align script.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align renice.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align logger.1 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align vipw.8 with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: fix return value table in fsck.8

Commint also has few alignments with howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

losetup: new -D option to delete all used loop devices

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Signed-off-by: Karel Zak <kzak@redhat.com>

losetup: print verbose messages if requested

verbose can't be > 1

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

Merge branch 'sys-utils-again' of https://github.com/kerolasa/lelux-utiliteetit

* 'sys-utils-again' of https://github.com/kerolasa/lelux-utiliteetit:
  cytune: fix printf type warning
  docs: mention long options in cytune.8
  cytune: coding style fixes
  cytune: refactor main(), new function query_tty_stats()
  cytune: use libc error printing facilities
  cytune: check numeric user inputs
  cytune: add long options and usage()
  docs: restructure flock.1 manual page
  flock: simplify strtotimeval()
  lib: [strutils] add strtod_or_err() function
  flock: use strutils.h to check numeric user input
  flock: use sysexit.h for all exit values
  flock: use function attributes
  flock: align with howto-usage-function.txt
  flock: use libc error printing facilities
  flock: move long_options struct to function scope
  flock: fix coding style
  docs: align fallocate.1 with howto-man-page.txt

lsblk: add udev support

[kzak@redhat.com: - enable udev support by default
                  - don't check for libudev.h
                  - minor udev code refactoring in lsblk.c]

Signed-off-by: Ilias Mamedov <arknir@yandex.ru>
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add prlimit to the TODO file

Signed-off-by: Karel Zak <kzak@redhat.com>

umount: add warning

It's better to inform users about reason why their request does not
makes sense :-)

Signed-off-by: Karel Zak <kzak@redhat.com>

umount: use new lib/loopdev.c code

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: fix loopdev deinitialization

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: support -o loop=<devname>

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: use new lib/loopdev.c code

Signed-off-by: Karel Zak <kzak@redhat.com>

include,xalloc: fix whitespace to be consistent

We use spaces for the rest of this file, so the random tabs within
xstrdup stand out.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

include,xalloc: check for NULL before calling strdup

This fixes a segfault in mount (and possibly elsewhere) when invoked
without a -t parameter.

Broken in 7ef9fd7 when the common xalloc.h libs were introduced.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

tests: add missing file

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: use loopdev debug facility

Signed-off-by: Karel Zak <kzak@redhat.com>

lib,loopdev: add debugu messages

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: chcpu and readprofile are sysadmin utils

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

cytune: fix printf type warning

conversion specifies type 'unsigned long' but the argument has type 'unsigned long *'

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: mention long options in cytune.8

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

cytune: coding style fixes

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

cytune: refactor main(), new function query_tty_stats()

This commit also moves global variables to the beginning of the
file, or to function scope where they belong.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

cytune: use libc error printing facilities

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

cytune: check numeric user inputs

Checks use strtol_or_err() from strutils.h

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

cytune: add long options and usage()

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: restructure flock.1 manual page

The commit aligns manual page with howto-man-page.txt, and adds example
section which I hope makes usage of this command easier.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

flock: simplify strtotimeval()

Retire private string to number conversion and use strtod_or_err() instead.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lib: [strutils] add strtod_or_err() function

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

flock: use strutils.h to check numeric user input

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

flock: use sysexit.h for all exit values

Additionally enhance readability of complex double "if shorthand's" by
making the segment to be few normal "if's".

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

flock: use function attributes

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

flock: align with howto-usage-function.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

flock: use libc error printing facilities

Retire global progname variable and use warn{,x} and err{,x}
functions. As a side effect of using err function the occurences of
err variable had to be converted to referrals to errno variable.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

flock: move long_options struct to function scope

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

flock: fix coding style

Sanitize indentation, spacing, brace positions, comment line lenghts and
positions etc. This commit does not change a thing in code.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: align fallocate.1 with howto-man-page.txt

Add also earlierly missing --version to the manual.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tests: add loopdev libmount test

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: support {offset,sizelimit}= foor loopdevs

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: add function to parse offsets/sizes

ipcrm: fix wrong subject in error messages for -m, -q, -s id options

This makes error messages print 'id' instead of 'key' using id options.

Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>