libblkid: fix compiler warning [-Wsign-compare]

Signed-off-by: Karel Zak <kzak@redhat.com>

include/optutils: remove unnecessary exclusive_option()

Signed-off-by: Karel Zak <kzak@redhat.com>

wdctl: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

prlimit: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

losetup: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

chcpu: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

wipefs: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

partx: use err_exclusive_options()

Signed-off-by: Karel Zak <kzak@redhat.com>

include/optutils: add err_exclusive_options()

This is improved implementation of exclusive_option(). The new
implementation:

  - uses regular struct option to compose error messages
  - relationships between options are described in one const static array
  - the current status is stored in one int array

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: fix dm_name usage

Signed-off-by: Karel Zak <kzak@redhat.com>

agetty: remove unnecessary sleep(10)

I'm quite sure this is not supposed to be here (apparently added as part
of commit 783b08fc1c6e5c906e).

Signed-off-by: Mantas Mikulėnas <grawity@gmail.com>

Revert "fdisk: de-duplicate disk label strings"

 ... because it's not expected that fdisk_label will be exported by
API and accessible for applications (like fdisk.c). It's private
libfdisk stuff.

This reverts commit e7818642600d6cd573a8e1ed5363fce52def5821.

fdisk: de-duplicate disk label strings

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>

fdisk: return success from sgi_create_disklabel

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

fdisk: fix compiler warning [-Werror=unused-variable]

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

dmesg: add fileback for SEEK_DATA

Reported-by: Bernhard Voelker <mail@bernhard-voelker.de>
Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: don't ignore 1MiB granularity on 512-byte sector devices

Note that +10MB is 100000 (10^N) and relative values (+<size>
convention) should be be aligned to the default grain (= 1 MiB).

Old version:

  Last sector, +sectors or +size{K,M,G} (2048-2047999, default 2047999): +10MB
  Partition 1 of type Linux and of size 9.5 MiB is set
  ...
  /dev/loop0p1            2048       21578        9765+  83  Linux
  /dev/loop0p2           21579       43062       10742   83  Linux

New version:
  Last sector, +sectors or +size{K,M,G} (2048-2047999, default 2047999): +10MB
  Partition 1 of type Linux and of size 10 MiB is set
  ...
  /dev/loop0p1            2048       22527       10240   83  Linux
  /dev/loop0p2           22528       43007       10240   83  Linux

Addresses: http://thread.gmane.org/gmane.linux.kernel.device-mapper.dm-crypt/5913/focus=5929
Reported-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: remove unused variables

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: make label API more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: API: add fdisk_label_change

[kzak@redhat.com: - rename function
                  - remove fdisk_create_default_disklabel()]

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: API: add verify to label operations

[kzak@redhat.com: - rename some functions]

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: API: add new partition to label operations

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: API: add write to label operations

[kzak@redhat.com: - rename functions
                  - use errno]

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: API: add delete partition to label operations

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: set label pointer in fdisk_create_default_disklabel()

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: API: add to label operations to context

The context structure is the fdisk API's main data type as it keeps all data
together. Add the label structure to it, so that the pt-specific operations can
be called from the context.

[kzak@redhat.com: - merge with latest changes
                  - don't allocate the label, use const pointer]

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: rename cxt->mbr buffer to cxt->firstsector

MBR is regular name for DOS partition table, let use less confusing
name for the buffer.

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: move label specific stuff to fdiskdoslabel.c

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: move DOS geometry code from generic part to label specific

 get_partition_table_geometry() should be called from DOS code

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: update oddinput test

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: fix error message for too small devices

 # touch ~/a
 # fdisk -l ~/a
 # fdisk: cannot open /root/a: Success

should be (at least):
 fdisk: cannot open /root/a: Invalid argument

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: (dos) cleanup function names

 - use 'write' in name for functions that really touch devices
 - use 'set' in name for functions that modify in-memory stuff

... otherwise it's unreadable mess

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: get_boot() has to die (step II.)

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: get_boot() has to die (step I.)

 - move generic stuff around "create disklabel" operation to API

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: move user geometry setting from fdisk.c to API

 - to avoid duplicate code
 - to remove fdisk_geom_set_cyls() from API

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: fix usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: add --reltime to print human readable deltas

[Jul20 09:50] device vnet0 entered promiscuous mode
[  +0.002248] virbr0: topology change detected, propagating
[  +0.000017] virbr0: port 2(vnet0) entered forwarding state
[  +0.000036] virbr0: port 2(vnet0) entered forwarding state
[  +0.001663] ADDRCONF(NETDEV_CHANGE): virbr0: link becomes ready
[ +10.480914] vnet0: no IPv6 routers present
[Jul20 14:35] xhci_hcd 0000:0e:00.0: WARN Event TRB for slot 3 ep 5 with no TDs queued?
[Jul20 19:23] EXT4-fs (sda2): re-mounted. Opts: (null)
[  +6.052980] EXT4-fs (sda2): re-mounted. Opts: (null)

Suggested by Linus:
http://thread.gmane.org/gmane.linux.kernel/1290886/focus=1296138

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg; cleanup time printing stuff

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: implement backwardly compatible --raw for /dev/kmsg

.. and if you really want raw data from /dev/kmsg then use dd(1) ;-)

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: cleanup exclusive_option() usage

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: add --follow feature

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: support --clear for kmsg

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: read /dev/kmsg (since kernel 3.5.0)

kmsg advantages:
  - extendible format
  - tags for messages
  - one read() returns one complete record

See kernel Documentation/ABI/testing/dev-kmsg.

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: add --syslog to force to old syslog(2) interface

... just for debugging or for people who somehow depends on syslog(2)
behavior.

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: refactoring for kmsg support

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: unify internal APIs

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: cleanup, move more stuff to control struct

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: move filename to control struct

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: check VFS mount options in mnt_diff_tables()

after "-o remount,ro" in unshared namespace is the original VFS entry
still read-write:

original:
42 21 8:2 / /boot rw,relatime - ext4 /dev/sda2 ro,user_xattr,acl,barrier=1,data=ordered

unshared + ro remount:
78 51 8:2 / /boot ro,relatime - ext4 /dev/sda2 ro,user_xattr,acl,barrier=1,data=ordered

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: (new) add --source and --target

In some cases (for example if only one mount argument is given) may be
mount request ambivalent:

# mount /foo

and fstab:

/dev/sda5 /foo rw 0 0
/foo /bar bind 0 0

the new options allows to be more explicit

        # mount --target /foo (mounts /dev/sda5)

# mount --source /foo (binds /foo to /bar)

It's possible to use the options together

# mount --source /dev/sda2 --target /home

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: allow to disable swap between source and target

In some cases (for example if only one mount argument is given) may be
mount request ambivalent:

# mount /foo

and fstab:

/dev/sda5 /foo rw 0 0
/foo /bar bind 0 0

The libmount allows to swap between source and target (if
source is not LABEL or UUID) by default. The new function

mnt_context_disable_swapmatch()

allows to disable this feature.

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO file

Signed-off-by: Karel Zak <kzak@redhat.com>

mkfs.cramfs: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

eject: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck.cramfs: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

ldattach: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

setarch: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

cytune: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

ipcmk: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

scriptreplay: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

tailf: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

colrm: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

raw: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

test_sysinfo: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

kill: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

su: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/match: fix compiler warning [-Wmissing-prototypes]

Signed-off-by: Karel Zak <kzak@redhat.com>

Merge branch '2012wk28'

* 2012wk28:
  translation: unify file open error messages
  translation: unify stat error messages
  utmpdump: use help and version output macros
  su: align with howto-usage-function
  fdisk: make if clause easier to read
  look: remove extra semicolon
  utmpdump: remove unused variable
  swapon: remove unused variables
  lib/loopdev: minor bug fix: add missing semicolon
  lib/pager: minor compiler warning fixes
  libblkid: remove duplicate entries in symbols

translation: unify file open error messages

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

translation: unify stat error messages

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

utmpdump: use help and version output macros

Done to reduce translation project work.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

su: align with howto-usage-function

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fdisk: make if clause easier to read

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

look: remove extra semicolon

The both macro SKIP_PAST_NEWLINE and location where macro is used will
not need semicolon at the end of line.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

utmpdump: remove unused variable

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

swapon: remove unused variables

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lib/loopdev: minor bug fix: add missing semicolon

Missing semicolon made test_loop_info() to return function
loopcxt_enable_debug() return value, which happen to be void.  I
suspect the loopcxt_enable_debug() was usually not executed, while it
should be.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lib/pager: minor compiler warning fixes

Add missing function prototype, and declare structure before use of it.

lib/pager.c:162:6: warning: no previous prototype for function 'setup_pager' [-Wmissing-prototypes]
lib/pager.c:20:29: warning: tentative definition of variable with internal linkage has incomplete non-array type 'struct child_process' [-Wtentative-definition-incomplete-type]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

libblkid: remove duplicate entries in symbols

The commit a0487b1cb5beffb8f6783476664b01e8833e0ea8 added symbol
dublicates.  The symbols should only be listed in BLKID_1.0 segment.

/usr/bin/ld.gold: warning: using 'BLKID_1.0' as version for 'blkid_probe_all' which is also named in version 'BLKID_2.15' in script
/usr/bin/ld.gold: warning: using 'BLKID_1.0' as version for 'blkid_probe_all_new' which is also named in version 'BLKID_2.15' in script
copying selected object files to avoid basename conflicts...

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fdisk: rename label probing functions

Rename check_$foo_label() to $foo_probe_label():

1/ 'probe' is more appropriate verb than 'check' for these functions
2/ making label name first part of the funciton name is IMO more
   friendly for tags completion (e.g. vim + cscope/ctags).

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

fdisk: don't call update_units() in label probes if not necessary

update_units() is called in _probe_labels before the label probes are
started, so we don't need to call it again in probers, unless it messes
around with geometry, which currently only check_sun_label() does (so
keep the call to update_units() in this one).

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

utmpdump: kill unused variable in follow_by_inotify()

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

libblkid: cast blkid_loff_t to unsigned long long

Get rid of gcc warning and fix build with -Werror

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

swapon: kill unused variables in show_table()

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

docs: man page syntax fixes

Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>

mount: ext4 option inode_readahead should be inode_readahead_blks in mount.8

Mount option inode_readahead should be inode_readahead_blks. Also the
value should be a power of 2.

Signed-off-by: Eryu Guan <guaneryu@gmail.com>

fdisk: API: add label probing functionality

This patch sets the initial layout for label specific operations. A
new fdisk_label structure is created that will hold all these ops,
like new, delete, write and probe, among others. For now only probing
is implemented. Once this design is established, a copy of the probed
label will be copied to the main context structure, where calling the
specific functions will save 'disklabel' checks. Debugging support is
added as well.

This patch passes regression tests and manually passes bsd, sun, dos
and sgi labels probes.

Reviewed-by: Petr Uzel <petr.uzel@suse.cz>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>

build-sys: add -Werror to UL_WARN_ADD test

 ... so revert previous patches with extra options for clang.

Sometimes is simple solution so obvious that it's invisible :-)

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: exclude some CC warnings for clang

Reported-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add exclude list to UL_ADD_WARN

Signed-off-by: Karel Zak <kzak@redhat.com>