rtcwake: do not duplicate argument strings

This is not necessary and prevents memory leaks.

Reported-by: Marek Otahal <markotahal@gmail.com>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>

blkid: don't ignore -i

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: uniformize the synopsis, remove "the the"

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

textual: tweak several manpages, mainly the blkid one

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

raw: remove constants from message strings; undo some abbrevs

Having a constant embedded within a message string prevents gettext from
picking up the rest of the string.  Also, translators may wish to change
word order; using a constant as a prefix or postfix makes this impossible.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

uuidd: add "-q" to synopsis, order options alphabetically

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

include: [c.h]: remove strings.h include dublicate

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

include: [c.h]: typeof to __typeof__ fix

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: update TODO

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tailf: tailf mention new help & version options in man page

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

tailf: use long options

This was TODO item from commit 947a7c9c. The patch also
introduces version and help switches.

[kzak@redhat.com: rewrite old_style_option()]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

logger: mention long option in logger man page

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

logger: use libc error printing facilities

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

logger: support long options

Use getopt_long and usage output changed to match long options.
This patch will also scrutiny argument of formerly undocumented
-P option.

[kzak@redhat.com: - include c.h]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

logger: fix variable type compiler warning

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

fsck: fix clang compiler warning

fsck.c:874:22: warning: format string is not a string literal
      (potentially insecure) [-Wformat-security]
errx(EXIT_USAGE, _(fs_type_syntax_error));
 ^~~~~~~~~~~~~~~~~~~~~~~

The issue was introduced in my commit 0a09eb4e, sorry.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

man page syntax fixes

Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>

mount: update mtab on "-f" and compiled with libmount

Reported-by: silvan minghetti <bu1137@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

umount: segfaults with inconsistent entry in /etc/fstab

Addresses: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/726283
Reported-by: Greg Brockman <gdb@gregbrockman.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

move struct option to .rodata

It does not make sense to have writable large arrays of "struct
option" on the stack.

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO file

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add term-utils/.gitignore

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move wall to term-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move mesg to term-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move reset to term-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move script and scriptreplay to term-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move setterm to term-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move agetty to term-utils

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add term-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix gcc warnings

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix EFI GPT uuid byte order

Intel uses little-endians for UUID, the rest of the sane world uses 16
byte big-endian array...

Reported-by: Andrew Lutomirski <luto@mit.edu>
Signed-off-by: Karel Zak <kzak@redhat.com>

kill: add -q sigval to use sigqueue(2)

Signed-off-by: Karel Zak <kzak@redhat.com>

kill: translate "-l <num>" to RT<n>

Signed-off-by: Karel Zak <kzak@redhat.com>

kill: add support for real-time signals

Newly supported syntax for RT signals:

 RT<n>   = SIGRTMIN + n
 RTMIN+<n> = SIGRTMIN + n
 RTMAX-<n> = SIGRTMAX - n

the final signal number has to be in interval [SIGRTMIN,SIGRTMAX].

Note that the "SIG" prefix is also supported for RT signals of course.

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=676297
Signed-off-by: Karel Zak <kzak@redhat.com>

rtcwake: test for available suspend modes

Signed-off-by: Lawrence Rust <lawrence@softsystem.co.uk>

dmesg.c: cleanups -- use err(), xalloc()

Signed-off-by: Marek Polacek <mpolacek@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: try to detect if PT is newer than LVM

LVM (pvcreate) wipes the begin of the device. If there is a PT in the
wiped area then LVM signature is obsolete.

 # pvcreate /dev/sdb
 # fdisk /dev/sdb

old version:
 # blkid -p -o udev /dev/sdb
 ID_FS_TYPE=LVM2_member

new version:
 # blkid -p -o udev /dev/sdb
 ID_PART_TABLE_TYPE=dos

Reported-by: Matej Cepl <mcepl@redhat.com>
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=679799
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: update libmount tests (add optstr output)

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: better "user" evaluation

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: don't export functions for vfs/fs/userspace mount options

Signed-off-by: Karel Zak <kzak@redhat.com>

ipcs: fix typo

Reported-by: Francesco Cosoleto <cosoleto@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO file

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: bitwise or TT_FL_ASCII with tt_flags instead of setting

Signed-off-by: Dave Reisner <d@falconindy.com>

hwclock: make RTC default to UTC time

If /etc/adjtime doesn't specify UTC or LOCAL, rtcwake defaults to UTC
and hwclock defaults to LOCAL.

Switch hwclock to meet the behaviour of rtcwake (default=UTC), also
matching the kernel's CONFIG_RTC_HCTOSYS behaviour.

The user impact of this change should be minimal, as anyone who has run
"hwclock --systohc" before will have their UTC/LOCAL choice already
recorded in /etc/adjtime.

Signed-off-by: Daniel Drake <dsd@laptop.org>

cfdisk: fix compiler warning

cfdisk.c: In function ‘menuUpdate’:
cfdisk.c:1034:25: warning: unused variable ‘ymargin’

Signed-off-by: Karel Zak <kzak@redhat.com>

cfdisk: remove unused vertical menu direction code

It isn't used and doesn't seem very important, as well as requires more
work to run properly.

Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>

scriptreplay: bug in argument check

Number of arguments cannot be at the same time too many and few.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

script: inform about long options in script manual page

[kzak@redhat.com: - use -V instead of -v]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

script: support for long options

[kzak@redhat.com: - use -V instead of -v
  - minor changes in usage()]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

script: use libc error printing facilities

[kzak@redhat.com: - use more verbose warnings]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

script: fix compiler warnings

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

getopt: fix '--unqote' typo in usage text

Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>

mkswap: fix compiler warning

mkswap.c: In function ‘main’:
mkswap.c:646:6: warning: too few arguments for format

Signed-off-by: Karel Zak <kzak@redhat.com>

doc: mention mkswap long options in man page

The update will also expand kernel version numbers to have a
month and year next to them. This should help users can get idea
how long, for example, swap v1 has been around.

[kzak@redhat.com: - modify synopsis, remove duplicate info about page size]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

mkswap: coding style unification

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mkswap: fix to compiler warnings

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mkswap: use EXIT_ values

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mkswap: support long options and check user inputs

[kzak@redhat-com: - mimor changes to usage()]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

lib: [strutils.c] more robust strtol checks

Signed-off-by: Karel Zak <kzak@redhat.com>

strutils: new wrapper function strtoll_or_err

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mkswap: use xalloc

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mkswap: use libc error messaging facilities

[kzak@redhat.com: - use "%s from %s" for -V output]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add tests for [u]mount regular file

Signed-off-by: Karel Zak <kzak@redhat.com>

umount: allow unmounting loopdev specified by associated file

Make it possible to unmount a filesystem on a loop device if it is
specified by associated backing file. It does not attempt to unmount
anything if there are more than one loop device associated with the
given file.

Umount looks for associated loopdevice(s) only if umount is called
with the regular file as an argument.

Before:
mount -o loop -t ext2 img mnt
umount -v img
> Could not find /home/puzel/upstream/util-linux/img in mtab
> umount: img: not mounted

After:
mount -o loop -t ext2 img mnt
umount -v img
> img is associated with /dev/loop0, trying to unmount it
> /dev/loop0 has been unmounted

[kzak@redhat.com: - fix memory leak in lomount.c]

Addresses: https://bugzilla.novell.com/show_bug.cgi?id=666161
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Signed-off-by: Karel Zak <kzak@redhat.com>

include: [xalloc.h]: mention strdup in the file description

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

lscpu: use xstrdup from xalloc.h

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

losetup: spelling fixes

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

hexdump: new usage(), xalloc and err.h stuff

New usage help screen and print version switch. Also fixes to
exit codes, util linux xmalloc replaced emalloc and every error
print is using libc error function.

[kzak@redhat.com: - minor changes in formatting and coding style]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

ipcs: really show all resources when -a and -i are combined

When you have more than one resource with the same id (but differing
types) combining -a and -i does not show all resources. This patch
corrects that.

Signed-off-by: Jens Kristian Søgaard <jens@mermaidconsulting.dk>

lsblk: fix readlink() usage

Reported-by: Steve Grubb <sgrubb@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

Revert "libmount: do not check for EAGAIN after flock()"

 Linux is not 100% POSIX compatible in this area...
 strace: "flock(3, LOCK_EX|LOCK_NB)   = -1 EAGAIN (Resource temporarily unavailable)"

This reverts commit 78d8c28f746bcc8d4e642c39669d8e58dea8d029.

Revert "libuuid: do not check for EAGAIN after flock()"

 Linux is not 100% POSIX compatible in this area...
 strace: "flock(3, LOCK_EX|LOCK_NB)   = -1 EAGAIN (Resource temporarily unavailable)"

This reverts commit d6c8d399b93f4646a90d0180fdcc1be35235a9c7.

build-sys: add uuid_generate_time_safe.3 .gitignore

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO file

Signed-off-by: Karel Zak <kzak@redhat.com>

chsh: fix gcc link() warn_unused_result warning

setpwnam.c:176:9: warning: ignoring return value of ‘link’, declared with attribute warn_unused_result

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck: fix -C parsing

Reported-by: Steve Grubb <sgrubb@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

tests: [cpuset] call free() for range

The free() before exit() is not so important, but let's keep the
example code nice and consistent.

Reported-by: Steve Grubb <sgrubb@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

chsh: fix small memory leak

Reported-by: Steve Grubb <sgrubb@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

login: does not ignore setgid() return code for non-roots

Reported-by: Steve Grubb <sgrubb@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: more robust whole-disk detection

In lib/wholedisk.c, i is set to 0. If fd was a -1, then at
line 18 geometry.start is used without it being initialized.

Reported-by: Steve Grubb <sgrubb@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

libuuid: move __uuid function to UUIDD_PRIVATE in uuid.sym

The private functions for uuidd should not be included in the normal
versioned part or the library.

Signed-off-by: Karel Zak <kzak@redhat.com>

libuuid: update manpage, mention uuid_generate_time_safe

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

libuuid: introduce uuid_generate_time_safe()

The problem with libuuid interface is that it is impossible to
inform the caller of uuid_generate_time() if the UUID was generated
in a safe manner (either via uuidd, or using the global clock state
counter).

This patch introduces new function,

int uuid_generate_time_safe(uuid_t out)

which can report whether the generated UUID is safe.

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

libuuid: __uuid_generate_time(): report if clock_seq is safe

Propagate return value from get_clock() through __uuid_generate_time().

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

libuuid: rename uuid__generate_* to __uuid_generate_*

Having uuid_generate_time and uuid__generate_time at
the same time is confusing. These functions are exported,
but not part of the official API (used by uuidd only).

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

libuuid: get_clock(): report if the clock_seq is safe

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

libuuid: do not use invalid file descriptor

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

libuuid: manpage spelling fixes

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

libuuid: fix test in get_clock()

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

uuidd: fix manpage: libuuid(3) does not exist

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

partx: improve clarity of some messages, gettextize two missed ones

[kzak@redhat.com: - use <disk> rather than <device> in
                    error/verbose messages]

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Karel Zak <kzak@redhat.com>

textual: improve the wording of some error and usage messages

[kzak@redhat.com: - cleanup lscpu(1) usage text
                  - use <disk> rather than <device> in partx(8)
                    usage text]

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Karel Zak <kzak@redhat.com>

textual: fix three typos in message strings and improve consistency

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

fsck: use xmalloc, warn & err and new usage

All compler errors reported by -Wall -Wextra -pedantic are fixed.

The patch also makes fsck to use xalloc instead of it's own malloc.
That will make fsck to exit, which could be good thing, at sections
where it previously did not.

Almost all print outs where touched, where various printfs where
converted to warn or err messages.

Finally theres a fix to counter wrap bug that could (very unlikely)
manifest itself if an user specifies same flag exactly UINT_MAX times.

[kzak@redhat.com: - coding style
                  - define XALLOC_EXIT_CODE
                  - use verbose++ in main()]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: favour small patches

http://www.spinics.net/lists/util-linux-ng/msg04084.html

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lib: [strutils] avoid integer overflow on large values

This is visible on a 2TB disk via lsblk, where a large partition
incorrectly displays as 1.171798692T instead of 1.8T. This is
corrected by using a uint64_t type instead of a simple int --
consistant with the type used in lsblk.c to represent the raw size in
bytes.

[kzak@redhat.com: - add EiB support
                  - add size_to_human_string() to regression tests]

Signed-off-by: Dave Reisner <d@falconindy.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

more: new usage output, and some trivial fixes

Usage output screen got to be completely rewrote. Aim is to
assist user to determe which switches to use without reading
manual page. The change also introduced new option to see command
version.

Determination if the executable name is `page' is now easy to see
in source, and effect of using the name is mentioned in manual
page.

Rest of the change is trivial; exit values to compiler warning
removals, magic constants to preprocessor definitions, symbolic
exit values, comment pretty printing and #endif markups.

[kzak@redhat.com: - coding style
                  - add __unused__ attribute to signal handlers]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>