Karel Zak [Mon, 2 May 2011 11:36:20 +0000 (13:36 +0200)]
docs: add Matej to AUTHORS
The original idea to have something like fallocate(1) is from Matej
Cepl -- his mkfile(1) prototype has been originally discussed on
coreutil mailing list. Thanks!
o Old school introduction back to the top of the source file.
o Indentation changes.
o Removal of void casting.
o Removal of braces from single statements.
o Unified format for comments.
o Comparison with W. Venema's code from 1993 to clean few comment
mysteries.
o Web referrals added to further explanation to near the code or
comments which some could find difficult to understand why.
o Clean up of comments.
o FIXME items added where attention is needed.
o Make functions static.
o Functions with same argument types use same argument order.
o Get rid of classic K&R style function declarations.
Please notice that this patch _should not_ affect how program
works e.g. this has no actual code changes.
Karel Zak [Thu, 21 Apr 2011 12:53:23 +0000 (14:53 +0200)]
libmount: add support for x-* mount comments
The current way how add any comment or extra information to /etc/fstab
is to use comment="" mount option. This is not too elegant and readable
if you want to add more than one comment.
It seems better to add any generic prefix that will be used for all
3rd-party userspace mount options.
Expected syntax is:
x-<application>-<options>[=<data>]
For example:
x-systemd-bar=managed
All x-* options (as well as comment=) are ignored by libmount and not
stored to the mtab file.
Requested-by: Lennart Poettering <lennart@poettering.net> Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Sun, 10 Apr 2011 10:16:15 +0000 (12:16 +0200)]
agetty: getopt case segment reordering
The case clause after getopts is in alphabetical order, just like
option string definition and manual page. The patch also convers
spaces to tabs in this code block.
Sami Kerola [Sun, 10 Apr 2011 10:16:14 +0000 (12:16 +0200)]
docs: agetty long options
Long options to manual page with the new --version and --help.
The manual page option order is also set to be the same as it is
in code. For the persons who don't see the order it is short
option case in sensitive alphabetical order.
Nick Holloway [Sun, 10 Apr 2011 12:35:56 +0000 (13:35 +0100)]
libblkid: remove test for non-zero head count in FAT superblock probe.
This change enables the auto-detection of the internal storage on a VTech
Kidizoom camera, which has a zero head count value in the superblock.
Microsoft documentation, "FAT: General Overview of On-Disk Format", states
that the sectors and heads fields are only relevant for media that have
a geometry.
The Linux kernel also does not require a non-zero head count, and can
manually mount the filesystem.
Signed-off-by: Nick Holloway <Nick.Holloway@pyrites.org.uk>
Some architectures like ARM place __init_end before .text section.
If any function in .init section is hit while profiling, readprofile
stops at __init_end. That means if we enable profiling at boot time,
the profiler probably hits init functions and readprofile does not
work well unless we reset profiling buffer with -r option.
Sami Kerola [Wed, 6 Apr 2011 19:31:00 +0000 (21:31 +0200)]
wall: remove global variables and support TMPDIR
The TMPDIR environment is preferred over _PATH_TMP in which a
file is created that is ultimately sent to terminals. This patch
will also fix compiler warnings and removes magical numbers,
which has not explanation.
Signed-off-by: Sami Kerola <kerolasa@iki.fi> Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Sat, 2 Apr 2011 20:56:50 +0000 (22:56 +0200)]
setterm: segfault with long dump file name
The patch will make too long path to be truncated to MAX_PATH
lenght. If user supplies too long file name that is caught at
fopen. Some users might find this unintuitive, so the altered
behavior will be mantioned in manual page.
Bug in earlier version was visible with a command bellow.
setterm -dump -file $(for i in $(seq 254); do printf x ; done)
Sami Kerola [Sat, 2 Apr 2011 16:11:09 +0000 (18:11 +0200)]
rev: option parsing bug fixed & long options added
The former getopts segment gave impression unknown options will
cause the program to exit with error and help is available with
-h. Neither work quite as designed, all unknown options made the
program to exit with success; and none of the options where
known.
The fix also has support for long options, and new --version
switch.
Karel Zak [Tue, 5 Apr 2011 14:38:06 +0000 (16:38 +0200)]
build-sys: remove check-news
I need to call "make distcheck" often during development phase to check
that all files are correctly added to Makefiles. The "check-new"
automake option is useless if $(VERSION) is generated from git.
Karel Zak [Tue, 5 Apr 2011 12:17:51 +0000 (14:17 +0200)]
libmount: fix parsing of mountinfo from 2.6.39
The /proc/self/mountinfo file uses " - " field as a separator between
optional fields and next fields in the file. The '-' char could be
used in the fields (for example in UUIDs), so it's necessary to check
for whole " - " string rather than for '-' char only.
Reported-by: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 31 Mar 2011 10:55:13 +0000 (12:55 +0200)]
lscpu: fix threads-per-core calculation
On Thu, Mar 24, 2011 at 01:45:34PM +0100, Jan Engelhardt wrote:
> On a 24-thread/6-core SPARC T1, lscpu would wrongly output "5
> threads per core".
>
> It seems that the 6c T1 is simply an 8c T1 where 2c are disabled
> (offering a lesser model for a lower price, and all that marketing
> fluff). So the machine description header of the 6c T1 reports 32
> threads, but only goes on to provide 24 elements thereafter, which
> is why Linux will report threads 24-31 as "offline". So far so good.
>
> But lscpu would take the number of all (online and offline) threads
> (32) and divides it by the number of online cores (6), which yields
> an odd 5.33 threads/core.
>
> Simply pick the number of online threads.
Based on Jan's patch.
Reported-by: Jan Engelhardt <jengelh@medozas.de> Signed-off-by: Karel Zak <kzak@redhat.com>
projects / thirdparty / util-linux.git / log
