]>
git.ipfire.org Git - thirdparty/util-linux.git/log
Karel Zak [Tue, 24 Jan 2012 10:40:15 +0000 (11:40 +0100)]
mount: (new) add more info about --stab to mount.8
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 24 Jan 2012 10:16:53 +0000 (11:16 +0100)]
libmount: remove fstab.d support
If you really need to store your configuration to a alternative files
then you have to explicitly specify the files or directories on
mount(8) command line by --fstab option.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 24 Jan 2012 10:04:18 +0000 (11:04 +0100)]
Revert "mount: enable fstab.d"
See discussion at https://lkml.org/lkml/2012/1/20/104
This reverts commit
d8ebc83ff2e9f879ac60a663c1685011a048f603 .
Karel Zak [Mon, 23 Jan 2012 19:52:19 +0000 (20:52 +0100)]
mount: (new) add --fstab to the man page
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 23 Jan 2012 19:31:23 +0000 (20:31 +0100)]
mount: (new) add --fstab <path> option
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 23 Jan 2012 19:22:11 +0000 (20:22 +0100)]
findmnt: support multiple --tab-file options
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 23 Jan 2012 19:20:36 +0000 (20:20 +0100)]
libmount: support dirs for mnt_table_parse_fstab(), add mnt_table_parse_dir()
Signed-off-by: Karel Zak <kzak@redhat.com>
Masatake YAMATO [Fri, 20 Jan 2012 04:00:34 +0000 (13:00 +0900)]
libmount: fix a potential memory leak at mnt_table_parse_dir
mnt_table_parse_dir in libmount/src/tab_parse.c calls
scandir, and then opendir. When the latter one, opendir is failed,
buffers allocated in scandir are not released.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Masatake YAMATO [Thu, 19 Jan 2012 04:28:41 +0000 (13:28 +0900)]
libmount: Use filter arg of scandir* to pickup /etc/fstab.d/*.fstab files
This patch is based on my last patch:
[PATCH 1/2] scandirat based mnt_table_parse_dir implementation
scandir* used in `mnt_table_parse_dir in libmount/src/tab_parse.c
can take filter function as an argument.
`mnt_table_parse_dir' picks up fstab files from namelist returned from
scandir* for itself. However, some parts of picking-up job can be done
in the filter function.
This patch introduces a new function `mnt_table_parse_dir_filter' to
share the code for picking-up job between two implementations of
`mnt_table_parse_dir_filter', scandir based and scandirat based.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Masatake YAMATO [Thu, 19 Jan 2012 04:16:20 +0000 (13:16 +0900)]
libmount: scandirat based mnt_table_parse_dir implementation
In comment of `mnt_table_parse_dir' of libmount/src/tab_parse.c:
/* TODO: it would be nice to have a scandir() implementation that
* is able to use already opened directory */
Nowadays glibc provides `scandirat'. This patch implements `scandirat'
based `mnt_table_parse_dir'.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Karel Zak [Mon, 23 Jan 2012 11:28:05 +0000 (12:28 +0100)]
mount: add info about libmount features to --version output
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 23 Jan 2012 11:27:01 +0000 (12:27 +0100)]
libmount: export info about library features
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 23 Jan 2012 10:15:41 +0000 (11:15 +0100)]
umount: (new) use the same exit codes as mount(8)
Note that old umount(8) uses 0 and 1 exit codes, and some
exceptions like 4 or 32.
The new umount(8) cleanups this mess and uses the same exit codes as
mount(8) (see mount(8) man page).
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 23 Jan 2012 09:55:35 +0000 (10:55 +0100)]
mount: (new) share exit codes by include/exitcodes.h
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 20 Jan 2012 13:17:08 +0000 (14:17 +0100)]
mount: (new) add source/target to error messages
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 20 Jan 2012 12:47:08 +0000 (13:47 +0100)]
mount: (new) improve mount -a exist codes and erroer messages
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 20 Jan 2012 12:14:26 +0000 (13:14 +0100)]
mount: (new) add selinux warning
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 20 Jan 2012 11:47:15 +0000 (12:47 +0100)]
findmnt: add note about LIBMOUNT_* env.variables
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 20 Jan 2012 11:15:37 +0000 (12:15 +0100)]
findmnt: revert --fstab behavior, add --tab-file option
The optional argument for -s, --fstab options (--fstab=file) is not
backwardly compatible, because command line with short options (e.g.
findmnt -snr) will be interpreted incorrectly.
This patch removes support for the optional --fstab argument and
introduces a new option --tab-file, for example:
findmnt --fstab --tab-file=/etc/fstab.foo
Reported-by: Juergen Daubert <jue@jue.li>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 19 Jan 2012 18:30:31 +0000 (19:30 +0100)]
flock: fix sizeof usage [clang -Wsizeof-pointer-memaccess]
flock.c:90:23: warning: argument to 'sizeof' in 'memset' call is the
same expression as the destination; did you mean to dereference it?
[-Wsizeof-pointer-memaccess]
memset(sa, 0, sizeof sa);
~~ ^~
Reported-by: Francesco Cosoleto <cosoleto@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 19 Jan 2012 12:15:03 +0000 (13:15 +0100)]
build-sys: improve ko-release-* scripts
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 19 Jan 2012 09:51:48 +0000 (10:51 +0100)]
build-sys: add ko-release-push script
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 19 Jan 2012 09:33:42 +0000 (10:33 +0100)]
build-sys: add ko-release-gen script
The script creates directory kernel.org/v<version>/, copy .xz tarball,
changelog, release notes and docs to the directory and sign all files by
gpg.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 19 Jan 2012 09:32:32 +0000 (10:32 +0100)]
build-sys: improve changelog target
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 18 Jan 2012 20:29:52 +0000 (21:29 +0100)]
build-sys: add changelog target
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 18 Jan 2012 19:10:44 +0000 (20:10 +0100)]
build-sys: enable .xz, disable .gz
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 18 Jan 2012 13:22:17 +0000 (14:22 +0100)]
build-sys: release++ (v2.21-rc1)
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 18 Jan 2012 13:20:09 +0000 (14:20 +0100)]
docs: add v2.21 ReleaseNotes
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 18 Jan 2012 10:39:05 +0000 (11:39 +0100)]
docs: update AUTHORS file
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 18 Jan 2012 10:31:55 +0000 (11:31 +0100)]
po: merge changes
Signed-off-by: Karel Zak <kzak@redhat.com>
Takeshi Hamasaki [Wed, 18 Jan 2012 10:26:08 +0000 (11:26 +0100)]
po: update ja.po (from translationproject.org)
David Prévot [Wed, 18 Jan 2012 10:25:50 +0000 (11:25 +0100)]
po: update fr.po (from translationproject.org)
Petr Pisar [Wed, 18 Jan 2012 10:25:50 +0000 (11:25 +0100)]
po: update cs.po (from translationproject.org)
Karel Zak [Tue, 17 Jan 2012 16:32:32 +0000 (17:32 +0100)]
build-sys: add sleepexit from login.c to smatch non-return functions
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 16:29:55 +0000 (17:29 +0100)]
hwclock: remove non-ANSI function declaration [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 16:28:46 +0000 (17:28 +0100)]
fsck: make fs->type usage more robust [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 16:23:01 +0000 (17:23 +0100)]
blockdev: remove non-ANSI function declaration [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 16:16:57 +0000 (17:16 +0100)]
libmount: fix bugs detected by [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 16:13:16 +0000 (17:13 +0100)]
build-sys: use $(MAKE) for checksmatch
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 16:02:34 +0000 (17:02 +0100)]
losetup: make xgetpass more robust
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:50:17 +0000 (16:50 +0100)]
dmesg: fix non-ANSI function declaration [smatch scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:45:58 +0000 (16:45 +0100)]
line: fix compiler warnings [-Wunused-parameter]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:43:45 +0000 (16:43 +0100)]
mount: fix __attribute__ keyword
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:40:37 +0000 (16:40 +0100)]
mount: fix compiler warnings [-Wunused-parameter -Wunused-variable]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:36:55 +0000 (16:36 +0100)]
losetup: fix compiler warnings [-Wpointer-sign -Wformat]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:33:19 +0000 (16:33 +0100)]
libmount: fix compiler warnings [-Wuninitialized -Wformat]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:31:45 +0000 (16:31 +0100)]
libmount: fix compiler warnings [-Wsign-compare]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:27:06 +0000 (16:27 +0100)]
sfdisk: fix poor coding style
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:26:08 +0000 (16:26 +0100)]
fdisk: fix poor coding style
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:22:11 +0000 (16:22 +0100)]
mount: remove duplicate includes
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:21:56 +0000 (16:21 +0100)]
lib,loopdev: remove duplicate includes
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:21:33 +0000 (16:21 +0100)]
sfdisk: remove duplicate includes
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 15:12:04 +0000 (16:12 +0100)]
libmount: ignore "defaults" mount option
... thanks to regression test!
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 14:48:20 +0000 (15:48 +0100)]
sfdisk: add note about alignment to the man page
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 14:48:14 +0000 (15:48 +0100)]
cfdisk: add note about alignment to the man page
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 17 Jan 2012 14:35:10 +0000 (15:35 +0100)]
test: refresh build-sys tests
Signed-off-by: Karel Zak <kzak@redhat.com>
Dave Reisner [Tue, 17 Jan 2012 01:17:55 +0000 (20:17 -0500)]
mount: avoid canonicalizing pseudofs paths
This fixes a display bug in the new mount wherein a psuedofs existing in
$PWD by name will be resolved and shown as a real mount point.
$ cd /tmp; mkdir nfsd; mount | grep nfsd
/tmp/nfsd on /proc/fs/nfsd type nfsd (rw,relatime)
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Francesco Cosoleto [Mon, 16 Jan 2012 05:36:13 +0000 (06:36 +0100)]
fdisk: fix last sector dialog bug after an incorrect input with suffix
If user input in a last sector dialog was out of range and with suffix, and if
this was followed by accepting the default value, then the used last sector was
erroneously default - 1.
Reported-by: Gerardo Exequiel Pozzi <vmlinuz386@yahoo.com.ar>
Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
Francesco Cosoleto [Mon, 16 Jan 2012 05:36:12 +0000 (06:36 +0100)]
fdisk: rename read_int_sx() and some related variables
Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
Karel Zak [Mon, 16 Jan 2012 13:35:10 +0000 (14:35 +0100)]
libmount: add MNT_OMODE_NOTAB
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 16 Jan 2012 12:22:28 +0000 (13:22 +0100)]
lsblk: add UUID to --fs output
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 16 Jan 2012 12:15:01 +0000 (13:15 +0100)]
libmount: cleanup post-umount operations
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 16 Jan 2012 11:29:27 +0000 (12:29 +0100)]
libmount: fix MS_BIND|MS_REC usage, improve some bitwise operations
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 16 Jan 2012 11:09:36 +0000 (12:09 +0100)]
libmount: add post-mount checks to detect ro/rw
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 16 Jan 2012 10:28:05 +0000 (11:28 +0100)]
libmount: avoid duplicate loopdevs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 13 Jan 2012 15:29:21 +0000 (16:29 +0100)]
mount: (new) print error messages
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 13 Jan 2012 15:27:50 +0000 (16:27 +0100)]
libmount: allow to toggle ro/rw and mount again
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 13 Jan 2012 13:37:09 +0000 (14:37 +0100)]
libmount: allow to use UUID and LABEL for owner/group mount options in fstab
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 13 Jan 2012 12:01:18 +0000 (13:01 +0100)]
libmount: add functions to export syscall/helpers status
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 20:51:29 +0000 (21:51 +0100)]
tests: fix mount/special to be compatible with libmount
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 20:51:00 +0000 (21:51 +0100)]
libmount: fix auto-loopdev
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 20:30:58 +0000 (21:30 +0100)]
libmount: support umount /path/file.img
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 19:37:21 +0000 (20:37 +0100)]
tests: add exceptions for libmount
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 15:52:32 +0000 (16:52 +0100)]
libmount: make options in fstab optional
.. to be compatible with old mount(8).
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 10:35:10 +0000 (11:35 +0100)]
tests: update tests with fdisk output
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 10:31:54 +0000 (11:31 +0100)]
tests: remove unssuported losetup -s
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 10:28:42 +0000 (11:28 +0100)]
tests: remove unexpected set -x
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 12 Jan 2012 10:15:53 +0000 (11:15 +0100)]
tests: cleanup paths
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 11 Jan 2012 16:54:04 +0000 (17:54 +0100)]
build-sys: suport static build for new [u]mount
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 11 Jan 2012 16:05:08 +0000 (17:05 +0100)]
build-sys: add --enable-new-mount
Now we have three versions of the mount(8) utility
* old mount(8)
--enable-mount [default]
* old mount(8) linked with libmount
This is this is necessary for systems without mtab file.
--enable-libmount-mount
- new mount(8)
This is completely new pure-libmount based mount(8).
--enable-new-mount
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 11 Jan 2012 15:17:06 +0000 (16:17 +0100)]
libmount: add --pass-fd to samples/mount
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 11 Jan 2012 15:16:00 +0000 (16:16 +0100)]
libmount: add support for encrypted loopdevs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 11 Jan 2012 14:45:36 +0000 (15:45 +0100)]
losetup: add note about non-root users to losetup.8
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 11 Jan 2012 14:17:06 +0000 (15:17 +0100)]
losetup: move xgetpass() to lib/xgetpass.c
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 11 Jan 2012 11:14:29 +0000 (12:14 +0100)]
build-sys: move swapon from mount/ to sys-utils/
... to make it independent on mount stuff.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 11 Jan 2012 10:43:42 +0000 (11:43 +0100)]
swapon: merge swap_constants.h into swapon.c
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 10 Jan 2012 15:48:37 +0000 (16:48 +0100)]
docs: add info about virt-what to TODO
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 10 Jan 2012 14:43:56 +0000 (15:43 +0100)]
mount: add hint that context= has to be quoted
Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=747038
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 10 Jan 2012 13:01:17 +0000 (14:01 +0100)]
mount: update info about check= mount option
Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=770172
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 9 Jan 2012 22:27:53 +0000 (23:27 +0100)]
losetup: add --partscan option
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 9 Jan 2012 22:22:04 +0000 (23:22 +0100)]
loopdev: improve debug messages
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 15 Nov 2011 11:35:23 +0000 (12:35 +0100)]
loopdev: support LO_FLAGS_PARTSCAN flag (kernel 3.2)
Signed-off-by: Karel Zak <kzak@redhat.com>
Davidlohr Bueso [Wed, 4 Jan 2012 23:02:11 +0000 (00:02 +0100)]
sfdisk: use is_blkdev
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Wanlong Gao [Tue, 27 Dec 2011 14:09:19 +0000 (22:09 +0800)]
blockdev: make functions static
make the functions in blockdev to statics.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Davidlohr Bueso [Wed, 4 Jan 2012 22:28:59 +0000 (23:28 +0100)]
lscpu: fix compiler warnings
The string format is not being passed triggering:
lscpu.c: In function ‘read_hypervisor’:
lscpu.c:545:4: warning: format not a string literal and no format arguments
lscpu.c: In function ‘get_cell_header’:
lscpu.c:904:2: warning: format not a string literal and no format arguments
lscpu.c:904:2: warning: format not a string literal and no format arguments
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Davidlohr Bueso [Wed, 4 Jan 2012 23:02:06 +0000 (00:02 +0100)]
blkdev: add is_blkdev function
We should have the most basic of checks in this library to see whether or not a block device is being used.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Karel Zak [Thu, 5 Jan 2012 16:01:19 +0000 (17:01 +0100)]
fdisk: remove PACKED macro
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 5 Jan 2012 15:58:56 +0000 (16:58 +0100)]
sfdisk: remove PACKED macro
Signed-off-by: Karel Zak <kzak@redhat.com>
Davidlohr Bueso [Tue, 20 Dec 2011 13:42:03 +0000 (14:42 +0100)]
sfdisk: remove do_warn
Replace it with warnx() instead.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Davidlohr Bueso [Tue, 20 Dec 2011 13:42:00 +0000 (14:42 +0100)]
sfdisk: remove fatal
Since fatal() exists with a standard 1 code, it can easily be replaced by errx(3).
The xalloc lib is also introduced in this patch.
[kzak@redhat,com: - fix coding style]
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>