libmount: potential null derefence [smatch scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: variable dereferenced before check [smatch scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: redundant null check on calling free() [smatch scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: use unsigned int for bitfields [smatch scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

include,c.h: include fcntl.h before check for O_CLOEXEC [smatch scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

fdformat: fix uninitialized variable

Spotted by EKOPath compiler.

Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>

build-sys: ddate typo fixed

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lscpu: allow read_cache() to be called for offline cpus

First check path before accessing files to be sure they actually exist. This is
necessary when also informations for offline CPUs will be printed.  Since we do
not necessarily know if "cpu is offline" means the same as "path does not
exist" just check for it.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

lscpu: simplify cache column output function

Simplify the logic to "always print a ',' for each cache except if it is the
last one.  This is also a preparation patch for printing the cache column for
offline CPUs where it would print one colon too much because of the current
logic.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

lscpu: fix cache output for extended parsable output

The extended parsable output prints a colon instead of comma between each
item. The case where a CPU doesn't belong to any cache was not converted.
Just fix this.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

lscpu: remove comma operator

Fix typo where the comma operator has been introduced.
Use a semicolon instead so we end up with simple assignment expressions.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

libuuid: add limits.h include for OPEN_MAX

Needed as definition for usage in close_all_fds().
Noticed on klibc build.

Signed-off-by: maximilian attems <max@stro.at>

agetty: double equals sign typo in opentty()

Reported-by: Francesco Cosoleto <cosoleto@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

script: fix building with --disable-nls

We should only include the libintl.h when NLS is requested.

This fixes issue when building util-linux with uClibc.

Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

write: fix path for freopen()

Reported-by: xinglp <xinglp@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: remove extra space only after time stamp

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: remove redundant __progname check

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: fix for non-CONFIG_PRINTK_TIME kernels

 * dmesg(1) incorrectly assumes that lines like "<6>\n"
   are broken.

 * it's more robust to assume the end of the record is "\n<"

 * print \n for empty lines

Reported-by: "Gabor Z. Papp" <gzp@papp.hu>
Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: use hypervisor generated topology information

The readable output prints also informations like cores per socket etc.
On newer kernel versions on s390 this information is available via
/proc/sysinfo. However it does not contain the layout of the guest but
the layout of the real machine.
Nevertheless this is better than random guessing with completely broken
numbers like we have it now on s390. If the information is not available
we fall back to old mechanism with more or less random numbers.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: fix fallback nthreads calculation

The fallback calculation of nthreads did not consider books.
In order to avoid division/multiply by/with zero make sure each number
used is at least "1".

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

lscpu: fix cpu map array sizes

Completely virtualized architectures like s390 may have multiple
virtual sockets and/or cores where each of them has a different
number of cores and cpus.
So the general assumption within the allocation scheme that e.g.
each socket contains the same number of cores is not necessarily
true. To make sure the arrays are always large enough we simply
allocate enough memory so that each array could hold cpu masks
for all present cpus.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

lscpu: fix s390 bogomips detection coding style

Just make the s390 bogomips detection line look like all others.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

sfdisk.8: fix formatting

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

raw: fix shadowing of minor function

Noticed while compiling against klibc:
raw.c: In function ‘query’:
raw.c:219:16: error: called object ‘minor’ is not a function

Rename variable from minor to minor_raw.
While at it mark the functions as static and small whitespace fixes
as asked by checkpatch.

[kzak@redhat.com: - rename variable at line 241 too]

Signed-off-by: maximilian attems <max@stro.at>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: don't install ru/ddate.1 if ddate disabled

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: release++ v2.20

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update v2.20 ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: update pl.po (from translationproject.org)

po: update nl.po (from translationproject.org)

po: update ja.po (from translationproject.org)

po: update de.po (from translationproject.org)

po: update cs.po (from translationproject.org)

lsblk: add note to the man page

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: tweak the formatting and wording of several disk-utils man pages

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

ionice: adjust synopsis and wording and formatting on the man page

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

look: adjust the formatting and some wording of the man page

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

vipw: (man page) uniformize header and footer, tweak the formatting

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

docs: tweak the formatting and wording of some text-utils man pages

Highlight the program name, use proper lowercase, remove
unneeded commas and articles, and add helpful hyphenation.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

docs: also uniformize headers and footers of troff-formatted man pages

Add two spaces as the required third argument of the date line to make
the specified date get used instead of today's date.  Incorporate the
section number into the page title, then use an empty section number,
so that specifying an explicit section/volume name will work.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

setarch: add --uname-2.6 option for personality flag UNAME26

[kzak@redhat.com: - minor change in usage()]

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Karel Zak <kzak@redhat.com>

flock: fix example in man page

Reported-by: Pierre Gaston <pierre.gaston@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix debug message

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: make some tests conditional to !Linux

This patch makes the following tests/actions conditional to "!Linux":

- Force cylinders as format instead of MB, even if user asked for MB.
  This solves a bug where if you use "-L -uM", set 1 as starting MB
  and the disk is larger than a certain size (about 1GB) the partition
  would start at sector 1 instead of 1MB due to cyl rounding.

- Warn about partitions not starting/ending on cyl boundaries.

- Check if CHS is ok.

I used the "!Linux" notation since it was already used elsewhere in
the code.

Signed-off-by: Giulio Orsero <giulioo@pobox.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

lib: [loopdev.c] correct qsort compare function

Reported-by: Andreas Schwab <schwab@linux-m68k.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

losetup: correct qsort compare function

Return the correct value from comparing the operands.

Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>

docs: drop the pluralization item with ngettext() in TODO file

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

scriptreplay: improve synopsis and formatting and wording in man page

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

pg: normalize formatting of the man page, and tweak some of its wording

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

uuidd: (man page) alphabetize the options

uuidd: (man page) repair the snipped up description of option -T

Also use lower case and no equals sign for option arguments,
return to using normal formatting macros, and indent the example.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

docs: uniformize the header and footer lines in man pages

Use dates without the day, use the full month name, put "util-linux" in
the lower left corner, and "User Commands" or "System Administration"
at the top center.

Also improve here and there the one-line program description.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

docs: update ReleaseNotes: fix typo in v2.20-ReleaseNotes

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>

docs: update ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add --enable-ddate

Don't build this crazy thing by default.

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: rename --enable-partx to --disable-partx

Note the partx command is (and always was) enabled by default on Linux.

Signed-off-by: Karel Zak <kzak@redhat.com>

ddate: fix St. Tib's Day in other languages

old version:
 $ LANG=de_DE.UTF8 ddate 29 2 2008
 St. Tib’s D, 3174 YOLD

new version:
 $ LANG=de_DE.UTF8 ddate 29 2 2008
 St. Tib’s Day, 3174 YOLD

Reported-by: Nick Erdmann <erdmann@date.upb.de>
Signed-off-by: Karel Zak <kzak@redhat.com>

tests: grammar fixes

Trivial change, "Cannot found" to "Cannot find".

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

losetup: allow to use --verbose with --all

Reported-by: Bernhard Voelker <mail@bernhard-voelker.de>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: release++ (v2.20-rc2)

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update v2.20 ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

pg: fix write_all() usage

Signed-off-by: Karel Zak <kzak@redhat.com>

mkfs.minix: fix write_all() usage

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: fix typo in man page

Reported-by: markus reichelt <ml@mareichelt.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
sk/sfdisk.8

sfdisk: slice help text into small chunks and improve its wording

[kzak@redhat.com: - use fputs(),
                  - use <var> convention]

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

sfdisk: (man page) use comma between short and long option instead of "or"

Also fix some erratic formatting, indent the third example too, drop
the trailing % prompt in examples, add a blank line before and after,
and improve the wording here and there.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>

blkid: fix typo

Signed-off-by: Karel Zak <kzak@redhat.com>

swapon: rewrite usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

losetup: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

write: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

wall: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

setterm: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

partx: use lowercase in usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

scriptreplay: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

script: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

mesg: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

partx: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

ipcmk: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

ldattach: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

mountpoint: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

rtcwake: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

renice: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

unshare: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

fstrim: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

fsfreeze: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

flock: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

fallocate: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

whereis: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

uuidgen: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

uuidd: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

rename: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

namei: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

mcookie: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

look: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

logger: indent usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

cal: indent usage()

Signed-off-by: Karel Zak <kzak@redhat.com>