]> git.ipfire.org Git - thirdparty/util-linux.git/commit
libmount: check for struct statx
authorMarkus Mayer <mmayer@broadcom.com>
Tue, 1 Aug 2023 19:59:27 +0000 (12:59 -0700)
committerKarel Zak <kzak@redhat.com>
Thu, 3 Aug 2023 10:04:12 +0000 (12:04 +0200)
commit1fc3471dfb8b3dc53af47115d0579cc6188f51d8
tree8f4fbaef627dbdc7a395886f2d2a6fbf99adb33c
parent5502e73d8f82af92975b7dec2d9641dc79170670
libmount: check for struct statx

Let's ensure struct statx exists before we try to use it. Checking for
the existence of linux/stat.h is not sufficient. This is because
[uapi/]linux/stat.h has existed since Linux 3.7, however struct statx
was only introduced with Linux 4.11.

The problem arises if one happens ot be using kernel headers from within
the aforementioned range, such as Linux 4.9.

  CC       libmount/src/la-utils.lo
In file included from libmount/src/utils.c:31:
./include/fileutils.h:100:33: warning: declaration of 'struct statx' will not
be visible outside of this function [-Wvisibility]
                    unsigned int mask, struct statx *stx)
                                              ^
libmount/src/utils.c:117:16: error: variable has incomplete type 'struct statx'
                struct statx stx = { 0 };
                             ^
libmount/src/utils.c:117:10: note: forward declaration of 'struct statx'
                struct statx stx = { 0 };
                       ^
libmount/src/utils.c:125:5: error: use of undeclared identifier 'STATX_TYPE'
                                STATX_TYPE
                                ^
libmount/src/utils.c:126:8: error: use of undeclared identifier 'STATX_MODE'
                                        | STATX_MODE
                                          ^
libmount/src/utils.c:127:8: error: use of undeclared identifier 'STATX_INO'
                                        | STATX_INO,
                                          ^
1 warning and 4 errors generated.
make[4]: *** [Makefile:11269: libmount/src/la-utils.lo] Error 1

Checking for the presence of struct statx explicitly avoids this
problem.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
configure.ac
include/fileutils.h
libmount/src/utils.c