builds: Move upvoting for testers to where it should be

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/buildservice/builds.py b/src/buildservice/builds.py
index 2d29beae1a0158b726ff46a7388a22d093a18b83..704579fadf20cca2c7ad276cc8e63b816a655aef 100644 (file)
--- a/src/buildservice/builds.py
+++ b/src/buildservice/builds.py
@@ -242,6 +242,10 @@ class Builds(base.Object):
                        for bug in commit.fixed_bugs:
                                build.add_bug(bug)
 
+                       # Upvote the build for the testers
+                       for tester in commit.testers:
+                               build.upvote(tester)
+
                # Create all automatic jobs
                build.create_autojobs(arches=arches)
 

diff --git a/src/buildservice/sources.py b/src/buildservice/sources.py
index 50430c56514f456000ffbcde92314083b2849030..2d4e2bbb35709ee5f86a754ffb4e0ba5fd193204 100644 (file)
--- a/src/buildservice/sources.py
+++ b/src/buildservice/sources.py
@@ -133,13 +133,9 @@ class Sources(base.Object):
                                                                # Import all packages in one swoop.
                                                                for pkg in pkgs:
                                                                        with self.db.transaction():
-                                                                               build = self.backend.builds.create_from_source_package(pkg,
+                                                                               self.backend.builds.create_from_source_package(pkg,
                                                                                        source.distro, commit=commit, type="release")
 
-                                                                               # Import any testers from the commit message
-                                                                               for tester in commit.testers:
-                                                                                       build.upvote(tester)
-
                                                        except:
                                                                if commit:
                                                                        commit.state = "failed"