]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
net: phy: phylink: Release link GPIO
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 10 May 2018 20:17:30 +0000 (13:17 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Aug 2018 05:50:35 +0000 (07:50 +0200)
[ Upstream commit daab3349ad1a69663ccad278ed71d55974d104b4 ]

We are not releasing the link GPIO descriptor with gpiod_put() which results in
subsequent probing to get -EBUSY when calling fwnode_get_named_gpiod(). Fix this
by doing the release in phylink_destroy().

Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/phy/phylink.c

index 1b2fe74a44eab81b0c2b690745cbbaa8df53e645..e4a6ed88b9cf0253efdfd98a53aa7d9ec799f94d 100644 (file)
@@ -561,6 +561,8 @@ void phylink_destroy(struct phylink *pl)
 {
        if (pl->sfp_bus)
                sfp_unregister_upstream(pl->sfp_bus);
+       if (!IS_ERR(pl->link_gpio))
+               gpiod_put(pl->link_gpio);
 
        cancel_work_sync(&pl->resolve);
        kfree(pl);