]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
net: hns3: return 0 and print warning when hit duplicate MAC
authorPeng Li <lipeng321@huawei.com>
Thu, 4 Apr 2019 08:17:51 +0000 (16:17 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Jun 2019 09:54:09 +0000 (11:54 +0200)
[ Upstream commit 72110b567479f0282489a9b3747e76d8c67d75f5 ]

When set 2 same MAC to different function of one port, IMP
will return error as the later one may modify the origin one.
This will cause bond fail for 2 VFs of one port.

Driver just print warning and return 0 with this patch, so
if set same MAC address, it will return 0 but do not really
configure HW.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index 340baf6a470cc1889b227494eab53eca8d67d3a2..4648c6a9d9e8654191060af4c88a7ac5549f71a2 100644 (file)
@@ -4300,8 +4300,11 @@ int hclge_add_uc_addr_common(struct hclge_vport *vport,
                return hclge_add_mac_vlan_tbl(vport, &req, NULL);
 
        /* check if we just hit the duplicate */
-       if (!ret)
-               ret = -EINVAL;
+       if (!ret) {
+               dev_warn(&hdev->pdev->dev, "VF %d mac(%pM) exists\n",
+                        vport->vport_id, addr);
+               return 0;
+       }
 
        dev_err(&hdev->pdev->dev,
                "PF failed to add unicast entry(%pM) in the MAC table\n",