]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
w90p910_ether: remove incorrect __init annotation
authorArnd Bergmann <arnd@arndb.de>
Mon, 10 Dec 2018 20:45:07 +0000 (21:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Jan 2019 09:00:59 +0000 (10:00 +0100)
[ Upstream commit 51367e423c6501a26e67d91a655d2bc892303462 ]

The get_mac_address() function is normally inline, but when it is
not, we get a warning that this configuration is broken:

WARNING: vmlinux.o(.text+0x4aff00): Section mismatch in reference from the function w90p910_ether_setup() to the function .init.text:get_mac_address()
The function w90p910_ether_setup() references
the function __init get_mac_address().
This is often because w90p910_ether_setup lacks a __init

Remove the __init to make it always do the right thing.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/nuvoton/w90p910_ether.c

index 4a67c55aa9f14ac61706562bc8c3908de63053df..11a9add818491461c7ffcccc8bf509e9631e743f 100644 (file)
@@ -912,7 +912,7 @@ static const struct net_device_ops w90p910_ether_netdev_ops = {
        .ndo_validate_addr      = eth_validate_addr,
 };
 
-static void __init get_mac_address(struct net_device *dev)
+static void get_mac_address(struct net_device *dev)
 {
        struct w90p910_ether *ether = netdev_priv(dev);
        struct platform_device *pdev;