]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
RDMA/rxe: Drop pointless checks in rxe_init_ports
authorKamal Heib <kamalheib1@gmail.com>
Sun, 5 Jul 2020 10:43:10 +0000 (13:43 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Sep 2020 08:46:25 +0000 (10:46 +0200)
[ Upstream commit 6112ef62826e91afbae5446d5d47b38e25f47e3f ]

Both pkey_tbl_len and gid_tbl_len are set in rxe_init_port_param() - so no
need to check if they aren't set.

Fixes: 8700e3e7c485 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/20200705104313.283034-2-kamalheib1@gmail.com
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/sw/rxe/rxe.c

index 8c3d30b3092d4a49df085d278e17d2dc6377c1fe..25267a620e0b56e4805b441e205c0d69bddf1893 100644 (file)
@@ -170,9 +170,6 @@ static int rxe_init_ports(struct rxe_dev *rxe)
 
        rxe_init_port_param(port);
 
 
        rxe_init_port_param(port);
 
-       if (!port->attr.pkey_tbl_len || !port->attr.gid_tbl_len)
-               return -EINVAL;
-
        port->pkey_tbl = kcalloc(port->attr.pkey_tbl_len,
                        sizeof(*port->pkey_tbl), GFP_KERNEL);
 
        port->pkey_tbl = kcalloc(port->attr.pkey_tbl_len,
                        sizeof(*port->pkey_tbl), GFP_KERNEL);