]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
ALSA: oxygen: Fix logical-not-parentheses warning
authorTomer Barletz <barletz@gmail.com>
Sun, 2 Aug 2015 09:08:57 +0000 (02:08 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Sep 2016 07:59:58 +0000 (09:59 +0200)
commit 8ec7cfce3762299ae289c384e281b2f4010ae231 upstream.

This fixes the following warning, that is seen with gcc 5.1:
warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses].

Signed-off-by: Tomer Barletz <barletz@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Cc: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/oxygen/oxygen_mixer.c

index 5988e044c5194e0650ab78c2ec4cf1eff069f8d0..259bf54a9df03178ec9ec6e693ac994a307bb4d7 100644 (file)
@@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl,
        int changed;
 
        mutex_lock(&chip->mutex);
-       changed = !value->value.integer.value[0] != chip->dac_mute;
+       changed = (!value->value.integer.value[0]) != chip->dac_mute;
        if (changed) {
                chip->dac_mute = !value->value.integer.value[0];
                chip->model.update_dac_mute(chip);