]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
ASoC: fsl_ssi: Remove .num_reg_defaults_raw from regmap_config
authorMarek Vasut <marex@denx.de>
Mon, 19 Sep 2016 19:30:29 +0000 (21:30 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 20 Sep 2016 17:55:42 +0000 (18:55 +0100)
This driver provides no .reg_defaults_raw in regmap_config, so
the .num_reg_defaults_raw is useless, and, in fact harmful. It
triggers kernel crash in regmap_init which tries to access the
register defaults.

Signed-off-by: Marek Vasut <marex@denx.de>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_ssi.c

index 50349437d9615107a3a08fa481b6b2d61612e51c..b73c102f1cf2eb72b452661903bc59b1451aa3a8 100644 (file)
@@ -177,7 +177,6 @@ static const struct regmap_config fsl_ssi_regconfig = {
        .val_bits = 32,
        .reg_stride = 4,
        .val_format_endian = REGMAP_ENDIAN_NATIVE,
-       .num_reg_defaults_raw = CCSR_SSI_SACCDIS / sizeof(uint32_t) + 1,
        .readable_reg = fsl_ssi_readable_reg,
        .volatile_reg = fsl_ssi_volatile_reg,
        .precious_reg = fsl_ssi_precious_reg,
@@ -1501,8 +1500,6 @@ static int fsl_ssi_probe(struct platform_device *pdev)
                 * don't have SACC{ST,EN,DIS} regs.
                 */
                regconfig.max_register = CCSR_SSI_SRMSK;
-               regconfig.num_reg_defaults_raw =
-                       CCSR_SSI_SRMSK / sizeof(uint32_t) + 1;
        }
 
        ret = of_property_match_string(np, "clock-names", "ipg");